Skip to content

Commit f7c1b93

Browse files
Don't retry 409
None of the listed reasons seem like they could be transient https://learn.microsoft.com/en-us/rest/api/storageservices/blob-service-error-codes
1 parent 3e46512 commit f7c1b93

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

test/azure_blobs_exception_tests.jl

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -247,12 +247,10 @@ end # @testitem
247247
# Returned when write operations conflict.
248248
# See https://learn.microsoft.com/en-us/rest/api/storageservices/blob-service-error-codes
249249
# See https://www.rfc-editor.org/rfc/rfc9110#status.409
250-
# TODO: We currently don't retry but maybe we should? This is probably a case where the
251-
# retry logic should add more noise to the backoff so that multiple writers don't collide on retry.
252250
nrequests = test_status(:GET, 409)
253-
@test nrequests == 1 + max_retries broken=true
251+
@test nrequests == 1
254252
nrequests = test_status(:PUT, 409)
255-
@test nrequests == 1 + max_retries broken=true
253+
@test nrequests == 1
256254
end
257255

258256
@testset "412: Precondition Failed" begin

0 commit comments

Comments
 (0)