Skip to content

Conversation

@hollasch
Copy link
Collaborator

@hollasch hollasch commented Sep 8, 2019

This adds styles for deleted lines and for highlighted (or new) lines.

Note that switching sub-styles in the middle of a code block will
swallow any leading blank line before, so in some cases you'll see two
blank lines in the tilde block where there would normally be one. This
will still render with a single blank line.

In addition to addressing existing cases, I've also found other cases
where highlighting illustrates incremental changes from one version to
the next, particularly in Ray Tracing In One Weekend (book 1).

See issue #14
Resolves #11

This adds styles for deleted lines and for highlighted (or new) lines.

Note that switching sub-styles in the middle of a code block will
swallow any leading blank line before, so in some cases you'll see two
blank lines in the tilde block where there would normally be one. This
will still render with a single blank line.

In addition to addressing existing cases, I've also found other cases
where highlighting illustrates incremental changes from one version to
the next, particularly in _Ray Tracing In One Weekend_ (book 1).

See issue #14
Resolves #11
@hollasch hollasch added this to the v2 - Web Release milestone Sep 8, 2019
@hollasch hollasch requested a review from a team September 8, 2019 22:52
@hollasch hollasch self-assigned this Sep 8, 2019
@hollasch
Copy link
Collaborator Author

Merging. Feel free to review/comment/object at any time.

@hollasch hollasch merged commit 490e87f into master Sep 11, 2019
@hollasch hollasch deleted the hollasch/code-highlighting branch September 11, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need solution to highlighted code lines

2 participants