Sanity pass for code blocks.

[hollasch]

• In One Weekend
  • chapter 1
  • chapter 2
  • chapter 3
  • chapter 4
  • chapter 5
  • chapter 6
  • chapter 7
  • chapter 8
  • chapter 9
  • chapter 10
  • chapter 11
  • chapter 12
• The Next Week
  • chapter 1
  • chapter 2
  • chapter 3
  • chapter 4
  • chapter 5
  • chapter 6
  • chapter 7
  • chapter 8
  • chapter 9
• The Rest Of Your Life
  • chapter 1
  • chapter 2
  • chapter 3
  • chapter 4
  • chapter 5
  • chapter 6
  • chapter 7
  • chapter 8
  • chapter 9

[trevordblack]

For instances of "float" and "double" and other types in the text, do we want them to be inlined, i.e.
floats and doubles.

[hollasch]

I tend to use “single precision” and “double precision”, or “32-bit floats” and “64-bit floats” in prose unless I'm talking specifically about the types. If the types are important, then yeah, generally I try to mark them up as code: float/double. I'm not super strict on this, as sometimes my prose looks like a clown car of type changes, so sometimes I'll drop the inline code style just so the text reads easier (not usually).

So generally, use code styling, but with an escape hatch when you need it.

[lorihollasch]

• General: should be hittable, not hitable

Book 1

Chapter 2

• "top part of my vec3 class":
  • Reorder include files to match src conventions
• "lots of vector operations":
  • dot: unclear (spaces needed?)
  • function signatures: inconsistent spacing, eg: ){ versus ) {
  • two spaces after e[x] in some methods
  • order methods consistently as + - * /
  • unbold unit_vector
• "change our main":
  • Reorder include files to match src conventions
  • Put spaces

Chapter 3

• "add antialiasing later":
  • Reorder include files to match src conventions
  • Remove *world and depth parameters from color

Chapter 5

• "motion blur at some point":
  • Put hit_record and { on same line
  • Make spacing in 2 temp calculations the same
• "And a list of objects":
  • Remove space between signature and hit_record_temp_rec
• "And the new main":
  • Reorder include files to match src conventions

Chapter 6

• "camera from before":
  • Add #include "random.h"
• "Main is also changed":
  • Make spacing in s's for loop consistent with i and j (int s = 0)

Chapter 7

• "is perfect for that":
  • Remove depth parameter from color

Chapter 8

• "in the hitable class below":
  • Put hit_record and { on same line
• "below marked with":
  • Make spacing in 2 temp calculations the same
• "For Lambertian materials":
  • Put const and { on same line
  • Remove blank space above vec3 albedo
• "The metal material":
  • Put const and { on same line
• "And add some metal":
  • List[0] Lambertian vec3 constants are different from Pete's
  • Make spacing in s's for loop consistent with I and j (int s = 0)
  • Add space between world, and 0 <- do elsewhere too?
• "sphere which yields":
  • Put const and { on same line

Chapter 9

• "And the dielectric material":
  • Put const and { on same line
  • Add curly braces back to if (refract) statement
• "If we try that out":
  • Remove 0.0 parameter from metal
• "This yields our full glass":
  • Put const and { on same line

Chapter 10

• "with crazy camera angles":
  • Change lookatfrom to be lookfrom

Chapter 11

• "rather than from a point":
  • Put const and { on same line

[lorihollasch]

Book 2:

Chapter 1

• "rays over a time period":
  • Camera's parameters layout differs from Book 1. Here there is one parameter per line versus several per line in Book 1
• "aperture open close":
  • Add space between time0 and time1

Chapter 2

• "Here is such a class":
  • One space instead of two between class and method?
• "will get optimized later":
  • Add curly braces for conditions in axis if statement (for consistency)?
  • Add space between time0,time1 (2 instances)

Chapter 3

• "any color a texture":
  • constant_texture: change open brace to open curly
  • books haven't had spaces between {} in empty constructors. Remove space(s) between { } (2 instances)
• "with a texture pointer":
  • Change "const (" to "const {"
• "a 3D checker pattern":
  • Remove space(s) between { } (2 instances)
• "If we add a new scene":
  • List[0] and list[1] both missing );

Chapter 4

• "And we can use that one some spheres":
  • Fix the above sentence (eg: "We can use that texture on some spheres")
  • Change "() (" to "() {"
• "we can linearly interpolate":
  • Change Z to 2
  • Remove ; from end of pexm_z calculation
• "The Perlin class is now":
  • Remove ; from end of pexm_z calculation
• "giving a marble-like effect":
  • Change ") ;" to ");"

Chapter 6 Rectangles and Lights

• "It's very simple":
  • Remove double spacing from "material {"
• "The actual xy_rect class":
  • Remove double spacing from "hitable {"
• "This is yz and xz"
  • Change to "xz and yz" to align with code for better readability
  • Remove double spacing from "hitable {"
• "Let's make the 5 walls":
  • Change hitable array size to 5? (was 6 in Pete's code; changed to 8 in new code)

Chapter 7 Instances

• "And the changes to Cornell is":
  • ^should be "changes are" or "change is"
  • Remove extraneous comma in second translate

Chapter 8 Volumes

• "And the changes to Cornell is":
  • Remove blank line before phase function calculation
• "And the hit function is":
  • Be consistent with short if statements. Some are on one line, some are on two lines.

Chapter 9 A Scene Testing All New Features

• "design decision":
  • *light calculation: remove space between ") )"
  • new sphere: add space between 400,200 and between 220,280
  • sphere in for loop has code line that is long enough to require scrolling
  • new bvh_node: add space between boxlist2,ns

[lorihollasch]

Book 3

Chapter 2 (Monte Carlo)

• "centered at the origin":
  • Reorder include files to match src conventions
  • Loop conditional should be i < N
• "a running estimate":
  • Reorder include files to match src conventions
• "try it both ways":
  • Reorder include files to match src conventions

Chapter 3 (1D MC Integration)

• "In fact it is exactly":
  • Reorder include files to match src conventions
• "and the code is":
  • Reorder include files to match src conventions
• "1 sample we get":
  • Reorder include files to match src conventions

Chapter 6 (Importance Sampling Materials):

• "generates the model":
  • Remove flip_normals from 3rd list item
  • Make lookfrom and lookat spacing consistent
• "color function gets":
  • Change hrec to rec

Chapter 7 (Generating Random Directions)

• "We can output":
  • z calculation is different - is that an error or deliberate?

Chapter 8 (Ortho-normal Bases)

• "use that axis":
  • Original book had pseudocode; new book has code block, but code isn't correct
• "using this to get":
  • Remove extra space in direction calculation ") )"

Chapter 9 (Sampling Lights Directly)

• "see the highlighted region"
  • Add highlighted region

Chapter 10 (Mixture Densities)

• "with the main changes highlighted"
  • Add highlighted region
• "And then change color"
  • Add light_shape to parameter list (see color code later in chapter)
  • Add open curly to "if (depth)" statement
  • Add highlighted region
• "plugging it into color"
  • Add highlighted region
  • Add open curly to "if (depth)" statement

Chapter 12 (Cleaning Up pdf Management)

• "And color() changes are small"
  • Add highlighted region
• "Metal is easy to fix"
  • Add highlighted region
• "an implicitly sampled ray"
  • Add highlighted region
• "We also need to change the block"
  • Add highlighted region
• "We assemble a list to pass in to color"
  • Did you mean to add all the extra code beyond hlist?