Fix: Remove Redundent Initialization to resolve reliability issue on Pypi. #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: furqan463 <[email protected]>
|
@mgovers I hope this resolves reliability issue on PyPi, unless there's some condition concerning some array rows being left untouched. Can't we run all those tests on this PR before releasing on Pypi. |
Unfortunately, SonarQube Cloud did not catch this on your previous PR because it skipped the analysis step because you created the PR from a fork; see also https://github.com/PowerGridModel/power-grid-model-io/blob/main/.github/workflows/sonar.yml#L51 
|
mgovers
reviewed
Sep 15, 2025
mgovers
approved these changes
Sep 15, 2025
There was a problem hiding this comment.
Cfr. #326 (comment) , the original suggestion was perfect. I hereby approve
Merged
via the queue into
PowerGridModel:main
with commit Sep 15, 2025
2cd812f
29 of 30 checks passed
|
Quality gate issue resolved: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR include:
Removed redundant initialisation lines that were causing reliability issue on Pypi concerning array values being set twice.