Pandapower_converter bug fix: Resolve bug with broadcasting #326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR include:
The changes proposed in PR #320 fixed known issues but created a bug in pgm_input_line function of pandapower_converter. in case of no data in column c0_nf_per_km, _get_attr_pp returns a single element array as it states broadcasting is responsibility of caller, but broadcasting was not handled, which creates error in assignment statemetns.
I've added another test to the /validation/converter/test_pandapower_converter_input.py, copied from pandapower tutorial power-grid-model_powerflow.ipynb, which fails on existing code.