Skip to content

Conversation

@furqan463
Copy link
Contributor

Changes proposed in this PR include:

The changes proposed in PR #320 fixed known issues but created a bug in pgm_input_line function of pandapower_converter. in case of no data in column c0_nf_per_km, _get_attr_pp returns a single element array as it states broadcasting is responsibility of caller, but broadcasting was not handled, which creates error in assignment statemetns.

I've added another test to the /validation/converter/test_pandapower_converter_input.py, copied from pandapower tutorial power-grid-model_powerflow.ipynb, which fails on existing code.

@furqan463
Copy link
Contributor Author

furqan463 commented Sep 10, 2025

@mgovers need your help with this, apart from above bug, I noticed reliability rating problem SonarQube due floating point equality. I replaced it with np.isclose which will resolve this issue but now a unit test is failing which I'm not sure how to fix.

Signed-off-by: furqan463 <[email protected]>
@furqan463
Copy link
Contributor Author

unit test issue resolved and code improved. pre-commit done.

@mgovers mgovers requested a review from nitbharambe September 10, 2025 09:39
@mgovers mgovers added the bug Something isn't working label Sep 10, 2025
@mgovers
Copy link
Member

mgovers commented Sep 10, 2025

Hi @furqan463 , thank you so much again for the contribution. @nitbharambe can you maybe pick this up? I am unfortunately not able to today or tomorrow.

@nitbharambe nitbharambe added this pull request to the merge queue Sep 10, 2025
@nitbharambe nitbharambe removed this pull request from the merge queue due to a manual request Sep 10, 2025
@nitbharambe nitbharambe added this pull request to the merge queue Sep 10, 2025
@nitbharambe
Copy link
Member

Thanks again @furqan463 !

Merged via the queue into PowerGridModel:main with commit 08ef8b4 Sep 10, 2025
29 of 30 checks passed
@furqan463
Copy link
Contributor Author

@mgovers @nitbharambe there is still a reliability issue on pypi.
I've checked that 2 No. lines causing this issue can be removed, the field is auto initialised with zero even when np.divide has some False entries in where.

@mgovers
Copy link
Member

mgovers commented Sep 12, 2025

@mgovers @nitbharambe there is still a reliability issue on pypi. I've checked that 2 No. lines causing this issue can be removed, the field is auto initialised with zero even when np.divide has some False entries in where.

hi @furqan463, good find. can you please open a PR for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants