Skip to content

Add support for Laravel > 5.5 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Add support for Laravel > 5.5 #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"keywords": ["laravel", "javascript", "language", "translations", "routes"],
"type": "library",
"require": {
"php": ">=5.5.9",
"illuminate/support": "5.1.*|5.2.*|5.3.*|5.4.*|5.5.*"
"php": ">=7.1",
Copy link

@willthorpe willthorpe Jul 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is public can we make this change removing 5.5.9 support?

Copy link
Contributor Author

@tpawelecpl tpawelecpl Jul 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not aware that it is public. But anyway, I think PHP 5.x is so ancient that if anyone wants to still use the package with such PHP version, will have to stay with 1.0 version. I'll create a new 2.0 tag, so if they have proper semver constraint, they won't be automatically upgraded. Anyway L5.5 requires PHP 7.x, so we have to change PHP constraint here.

Copy link

@willthorpe willthorpe Jul 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure that is fine

"illuminate/support": "^5.1"
Copy link

@willthorpe willthorpe Jul 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we also want to do v6/7/8/9 while we are here?

Copy link

@willthorpe willthorpe Jul 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this branch Adrien already made https://github.com/Pod-Point/laravel-javascript-lang/pull/1/files

Copy link
Contributor Author

@tpawelecpl tpawelecpl Jul 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather do it step by step. I don't want to say it's gonna work with 9.x if won't be tested with this version. Right now we are upgrading Laravel to 5.8, so intentionally prevented it to be installed with 6.x and above.

},
"license": "MIT",
"autoload": {
Expand Down