Add support for Laravel > 5.5 #2
Conversation
| "require": { | ||
| "php": ">=5.5.9", | ||
| "illuminate/support": "5.1.*|5.2.*|5.3.*|5.4.*|5.5.*" | ||
| "php": ">=7.1", |
There was a problem hiding this comment.
As this is public can we make this change removing 5.5.9 support?
There was a problem hiding this comment.
I was not aware that it is public. But anyway, I think PHP 5.x is so ancient that if anyone wants to still use the package with such PHP version, will have to stay with 1.0 version. I'll create a new 2.0 tag, so if they have proper semver constraint, they won't be automatically upgraded. Anyway L5.5 requires PHP 7.x, so we have to change PHP constraint here.
| "php": ">=5.5.9", | ||
| "illuminate/support": "5.1.*|5.2.*|5.3.*|5.4.*|5.5.*" | ||
| "php": ">=7.1", | ||
| "illuminate/support": "^5.1" |
There was a problem hiding this comment.
Not sure if we also want to do v6/7/8/9 while we are here?
There was a problem hiding this comment.
Like this branch Adrien already made https://github.com/Pod-Point/laravel-javascript-lang/pull/1/files
There was a problem hiding this comment.
I'd rather do it step by step. I don't want to say it's gonna work with 9.x if won't be tested with this version. Right now we are upgrading Laravel to 5.8, so intentionally prevented it to be installed with 6.x and above.
2 participants
Card: https://podpoint.atlassian.net/browse/SWP-5141
In order to use this package after upgrading Partner Portal to L5.6, we need to change the semver rule for
illuminate/supportpackage, so it's supported up to L5.8.