-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Dependency import fixes #17938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency import fixes #17938
Changes from all commits
3f81890
39c751c
afd4273
bb561d7
a86f5b6
a5657ab
89b0df5
6c8d5a6
436681b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"name": "@pipedream/acelle_mail", | ||
"version": "0.1.0", | ||
"version": "0.1.1", | ||
"description": "Pipedream Acelle Mail Components", | ||
"main": "acelle_mail.app.mjs", | ||
"keywords": [ | ||
|
@@ -11,5 +11,8 @@ | |
"author": "Pipedream <[email protected]> (https://pipedream.com/)", | ||
"publishConfig": { | ||
"access": "public" | ||
}, | ||
"dependencies": { | ||
"@pipedream/platform": "^3.1.0" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"name": "@pipedream/affinda", | ||
"version": "0.1.0", | ||
"version": "0.1.1", | ||
"description": "Pipedream Affinda Components", | ||
"main": "affinda.app.mjs", | ||
"keywords": [ | ||
|
@@ -11,5 +11,8 @@ | |
"author": "Pipedream <[email protected]> (https://pipedream.com/)", | ||
"publishConfig": { | ||
"access": "public" | ||
}, | ||
"dependencies": { | ||
"@pipedream/platform": "^3.1.0" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"name": "@pipedream/aircall", | ||
"version": "0.2.0", | ||
"version": "0.2.1", | ||
"description": "Pipedream Aircall Components", | ||
"main": "aircall.app.mjs", | ||
"keywords": [ | ||
|
@@ -11,5 +11,8 @@ | |
"author": "Pipedream <[email protected]> (https://pipedream.com/)", | ||
"publishConfig": { | ||
"access": "public" | ||
}, | ||
"dependencies": { | ||
"@pipedream/platform": "^3.1.0" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"name": "@pipedream/beanstalkapp", | ||
"version": "0.0.3", | ||
"version": "0.0.4", | ||
"description": "Pipedream Beanstalk Components", | ||
"main": "beanstalkapp.app.mjs", | ||
"keywords": [ | ||
|
@@ -11,5 +11,8 @@ | |
"author": "Pipedream <[email protected]> (https://pipedream.com/)", | ||
"publishConfig": { | ||
"access": "public" | ||
}, | ||
"dependencies": { | ||
"@pipedream/platform": "^3.1.0" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"name": "@pipedream/clientify", | ||
"version": "0.1.0", | ||
"version": "0.1.1", | ||
"description": "Pipedream Clientify Components", | ||
"main": "clientify.app.mjs", | ||
"keywords": [ | ||
|
@@ -11,5 +11,8 @@ | |
"author": "Pipedream <[email protected]> (https://pipedream.com/)", | ||
"publishConfig": { | ||
"access": "public" | ||
}, | ||
"dependencies": { | ||
"@pipedream/platform": "^3.1.0" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,24 @@ | ||
{ | ||
"name": "@pipedream/coassemble", | ||
"version": "0.0.3", | ||
"version": "0.0.4", | ||
"description": "Pipedream Coassemble Components", | ||
"main": "dist/app/coassemble.app.mjs", | ||
"keywords": [ | ||
"pipedream", | ||
"coassemble" | ||
], | ||
"files": ["dist"], | ||
"files": [ | ||
"dist" | ||
], | ||
"homepage": "https://pipedream.com/apps/coassemble", | ||
"author": "Pipedream <[email protected]> (https://pipedream.com/)", | ||
"publishConfig": { | ||
"access": "public" | ||
}, | ||
"dependencies": { | ||
"@pipedream/platform": "^3.1.0" | ||
}, | ||
"devDependencies": { | ||
"@pipedream/types": "^0.3.2" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -1,6 +1,6 @@ | ||||||||||||||||||||
{ | ||||||||||||||||||||
"name": "@pipedream/codeq_natural_language_processing_api", | ||||||||||||||||||||
"version": "0.0.2", | ||||||||||||||||||||
"version": "0.0.3", | ||||||||||||||||||||
"description": "Pipedream Codeq Natural Language Processing API Components", | ||||||||||||||||||||
"main": "codeq_natural_language_processing_api.app.mjs", | ||||||||||||||||||||
"keywords": [ | ||||||||||||||||||||
|
@@ -11,5 +11,8 @@ | |||||||||||||||||||
"author": "Pipedream <[email protected]> (https://pipedream.com/)", | ||||||||||||||||||||
"publishConfig": { | ||||||||||||||||||||
"access": "public" | ||||||||||||||||||||
}, | ||||||||||||||||||||
"dependencies": { | ||||||||||||||||||||
"@pipedream/platform": "^3.1.0" | ||||||||||||||||||||
} | ||||||||||||||||||||
Comment on lines
+15
to
17
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Add Unlike the other updated packages, this component did not add the typings package moved in this PR. If the source imports from "@pipedream/platform": "^3.1.0"
+},
+ "devDependencies": {
+ "@pipedream/types": "^0.1.6"
} 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents
|
||||||||||||||||||||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"name": "@pipedream/craftmypdf", | ||
"version": "0.1.0", | ||
"version": "0.1.1", | ||
"description": "Pipedream CraftMyPDF Components", | ||
"main": "craftmypdf.app.mjs", | ||
"keywords": [ | ||
|
@@ -11,5 +11,8 @@ | |
"author": "Pipedream <[email protected]> (https://pipedream.com/)", | ||
"publishConfig": { | ||
"access": "public" | ||
}, | ||
"dependencies": { | ||
"@pipedream/platform": "^3.1.0" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"name": "@pipedream/crove_app", | ||
"version": "2.0.3", | ||
"version": "2.0.4", | ||
"description": "Pipedream Crove Components", | ||
"main": "crove_app.app.mjs", | ||
"keywords": [ | ||
|
@@ -11,5 +11,8 @@ | |
"author": "Pipedream <[email protected]> (https://pipedream.com/)", | ||
"publishConfig": { | ||
"access": "public" | ||
}, | ||
"dependencies": { | ||
"@pipedream/platform": "^3.1.0" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"name": "@pipedream/daffy", | ||
"version": "0.1.0", | ||
"version": "0.1.1", | ||
"description": "Pipedream Daffy Components", | ||
"main": "daffy.app.mjs", | ||
"keywords": [ | ||
|
@@ -11,5 +11,11 @@ | |
"author": "Pipedream <[email protected]> (https://pipedream.com/)", | ||
"publishConfig": { | ||
"access": "public" | ||
}, | ||
"dependencies": { | ||
"@pipedream/platform": "^3.1.0" | ||
}, | ||
"devDependencies": { | ||
"@pipedream/types": "^0.3.2" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Confirm
@pipedream/types
is not required at runtime@pipedream/types
was moved todevDependencies
, which is the correct place as long as it’s only used for type-checking / build-time tooling.Please double-check that no runtime
import
/require
of this package exists in the Amplenote component code.Run a quick search to verify:
🏁 Script executed:
Length of output: 443
Move
@pipedream/types
intodependencies
This package is imported at runtime in your component code, so it must be available in production:
• components/amplenote/app/amplenote.app.ts
• components/amplenote/actions/create-task/create-task.ts
• components/amplenote/actions/create-note/create-note.ts
Update components/amplenote/package.json accordingly:
📝 Committable suggestion
🤖 Prompt for AI Agents