Dependency import fixes #17938
Dependency import fixes #17938
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
WalkthroughThis change updates the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (41)
✅ Files skipped from review due to trivial changes (18)
🚧 Files skipped from review as they are similar to previous changes (23)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 29
🔭 Outside diff range comments (2)
components/rss/package.json (1)
24-31: Align@pipedream/platformand@pipedream/typesversions across all componentsWe’ve observed a wide range of pinned versions in other packages versus what’s in
components/rss/package.json:• @pipedream/platform
– Current in RSS component:^1.4.0
– Other components use versions spanning^0.9.0→^3.1.0(including 1.x, 2.x and 3.x)
→ Please decide on the target major (e.g. the latest 3.x API) and bump this dependency accordingly to avoid multiple installs and runtime mismatches.• @pipedream/types
– Current in RSS component:^0.3.2
– Other components use both 0.1.x (e.g.^0.1.6) and 0.3.x (e.g.^0.3.0) ranges
→ Confirm which major version is intended and ensure all packages reference the same one to prevent subtle type errors.File to update:
•components/rss/package.json(Lines 24–31)components/google_tag_manager/package.json (1)
15-17: Upgrade@pipedream/platformto v3 or document the v1 requirementThis package still references
^1.5.1. Aligning with the v3 range adopted by other components prevents duplicate framework copies and eases maintenance.- "@pipedream/platform": "^1.5.1" + "@pipedream/platform": "^3.1.0"If v1 is intentionally required, please add a comment explaining the constraint.
♻️ Duplicate comments (3)
components/beanstalkapp/package.json (1)
15-17: Same note as in Affinda – consider@pipedream/typesunder devDependenciesSee earlier comment; applies identically here.
components/metaphor/package.json (1)
15-17: Same note as in Affinda – consider@pipedream/typesunder devDependenciesSee earlier comment; applies identically here.
components/listen_notes/package.json (1)
15-17: Same note as in Affinda – consider@pipedream/typesunder devDependenciesSee earlier comment; applies identically here.
🧹 Nitpick comments (35)
components/onfleet/package.json (1)
22-24: Align@pipedream/typesversion with the rest of the repoOther components in this PR use
@pipedream/types^0.3.2, but several still reference older ranges (e.g.^0.1.x). Consider bumping all packages together to avoid multiple copies of the same library in the dependency graph.components/pushbullet/package.json (1)
15-18: SDK + dependency versions
@pipedream/platformis on^3.0.0(one minor behind^3.1.0). Suggest bumping to keep a single version across the workspace.No issues with adding
form-data@^4.0.0, but note that v4 drops Node < 12 support—fine for our baseline.- "@pipedream/platform": "^3.0.0", + "@pipedream/platform": "^3.1.0",components/openai/package.json (1)
23-25: Bump@pipedream/typesto the latest series for feature parityThe rest of the codebase has converged on
^0.3.x. Remaining on^0.1.4misses newer prop helpers and typings (e.g.,auth: {}improvements) and may cause lock-file churn when packages are installed together.- "@pipedream/types": "^0.1.4", + "@pipedream/types": "^0.3.2",components/lettria/package.json (1)
12-17: Add@pipedream/typesto devDependencies for consistencyRuntime deps look good, but this component is one of the few that still ships without the typings package. Adding it keeps editors happy and avoids inconsistent local build tooling.
"dependencies": { "@pipedream/platform": "^3.1.0" + }, + "devDependencies": { + "@pipedream/types": "^0.3.2" }components/azure_storage/package.json (1)
15-19: Consider adding@pipedream/typestodevDependenciesfor type-safety consistencyMost components in this PR declare the types package under
devDependencies. Adding it here keeps tooling behaviour uniform across the repo.components/imgur/package.json (1)
18-21:form-datadependency looks correct – ensure Node-nativeURLSearchParamsisn’t sufficientMany HTTP libraries accept
URLSearchParamsor plain objects; adopting them avoids an extra dependency. If multipart upload is required, keepingform-datais justified.components/one_ai/package.json (1)
15-17: Missing@pipedream/typesdevDependencyMost TS-based components include
@pipedream/typesfor shared typings. If this component uses the Pipedream SDK in TypeScript, you’ll lose IntelliSense and may get build errors. Consider adding:"devDependencies": { + "@pipedream/types": "^0.3.2" }components/firmao/package.json (1)
15-17: Add dev-time typings for consistencyGood call on introducing
@pipedream/platform^3.1.0. For parity with other components, add@pipedream/typestodevDependenciesso contributors get correct type definitions during development.components/affinda/package.json (1)
15-17: Dependency change looks good, but dev-only typings are missingRuntime addition of
@pipedream/platform@^3.1.0is correct, yet most components also carry@pipedream/typesin devDependencies for editor / build-time typings. Double-check if this component’s source imports that package; if so, add it underdevDependenciesto avoid leaking it into the production bundle.components/infinity/package.json (1)
15-17: Consider adding@pipedream/typestodevDependenciesfor type-safe buildsMost components in this PR add
"devDependencies": { "@pipedream/types": "^0.1.4" }Doing the same here keeps the repo consistent and avoids TypeScript compile-time gaps when this component is built in isolation.
If the component truly has no build step that relies on the types, feel free to ignore.components/clientify/package.json (1)
15-17: Minor: add@pipedream/typesto match the standard templateFor parity with other components updated in this PR:
"dependencies": { "@pipedream/platform": "^3.1.0" }, + "devDependencies": { + "@pipedream/types": "^0.1.4" + }Not blocking, but helps keep scaffolding uniform.
components/mattermost/package.json (1)
21-23: Optional: standardise@pipedream/typesversionHere you pin
@pipedream/typesto^0.3.0, whereas most other components use^0.1.4. If no v0.3-specific APIs are required, consider downgrading (or upgrading all other components) for consistency.components/cloudmersive/package.json (1)
22-24: Keep type-only dependency versions consistent
@pipedream/typesis locked at^0.1.4here, but some components were upgraded to^0.3.0. If you decide to bump across the board (see previous comment), adjust this entry as well.components/godial/package.json (1)
12-18: Verify if type helpers are requiredSimilar to the Plecto package, this component adds the runtime
@pipedream/platformbut not@pipedream/types. Double-check the source; add todevDependenciesif any@pipedream/typesimport exists.components/niftyimages/package.json (1)
21-23: Sync type dependency with the rest of the repoUpgrade to
^0.3.0(or lower everything else) for uniformity.components/buy_me_a_coffee/package.json (1)
18-23: Inconsistent dependency versions – please verify
Other components in this PR pin@pipedream/typesto^0.1.6, while this package uses^0.1.4. Likewise,@pipedream/platformis on^1.2.0whereas some sibling components jump to^3.1.0. Double-check that the older versions are intentional and that the component compiles against them.components/google_my_business/package.json (1)
16-21:@pipedream/platformstill on v1.x while peers moved to v3.x
Keeping the dependency at^1.6.0may miss bug fixes and new helpers available in the 3.x line. Ensure there’s a hard requirement preventing an upgrade; otherwise align to^3.1.0for consistency.components/neverbounce/package.json (1)
18-23: Out-of-date dependency pins
@pipedream/platformis pegged at^1.1.1(two major versions behind others) and@pipedream/typesat^0.1.4. Confirm that upgrading won’t break the build; if safe, bring them up to parity.components/reversecontact/package.json (1)
16-21: Dependency drift
Platform pinned to^1.3.0, types to^0.1.4. Consider updating to the latest major / minor versions used elsewhere in the repo for easier maintenance unless there’s a compatibility reason.components/aircall/package.json (1)
12-17: Missing@pipedream/typesin devDependencies
This component adds the runtime@pipedream/platformdep (👍) but doesn’t add@pipedream/typestodevDependencies, unlike the other updated components. Add it for consistency and to avoid TS type resolution issues during development.components/mem/package.json (1)
12-17: Add@pipedream/typesunderdevDependenciesfor type safety parity
Unlike other updated packages, this component did not introduce@pipedream/types. Including it ensures editors and CI benefit from the same typed SDK helpers."dependencies": { "@pipedream/platform": "^3.1.0" }, + "devDependencies": { + "@pipedream/types": "^0.1.4" + }components/eodhd_apis/package.json (1)
12-17: Optional: include@pipedream/typesto mirror other components
If type helpers are used during development, consider adding them todevDependenciesfor IDE support."dependencies": { "@pipedream/platform": "^3.1.0" }, + "devDependencies": { + "@pipedream/types": "^0.1.4" + }components/ipbase/package.json (1)
15-17: Consider adding@pipedream/typestodevDependenciesfor consistencyMost components now declare
@pipedream/typesunderdevDependenciesso editors get proper typings without bundling them at runtime. Adding it here would keep the dependency layout uniform across packages and avoid type-resolution drift when this component is opened in isolation."dependencies": { "@pipedream/platform": "^3.1.0" - } + }, + "devDependencies": { + "@pipedream/types": "^0.3.2" + }components/raven_tools/package.json (1)
21-23: Bump@pipedream/typesto latest to avoid mismatched type definitionsOther components use
^0.3.x; staying on^0.1.4may miss new prop helpers and cause compilation errors when packages are co-installed.- "devDependencies": { - "@pipedream/types": "^0.1.4" - } + "devDependencies": { + "@pipedream/types": "^0.3.2" + }components/getemails/package.json (1)
15-17: Optional: declare typings indevDependenciesIf this component relies on Pipedream helper types during build or in JS-doc, consider adding
@pipedream/typesunderdevDependencies, mirroring the pattern adopted in other packages.components/placid/package.json (1)
15-17: Optional: add@pipedream/typesfor editor / build-time typingsSimilar to other updated components, adding the typings package under
devDependencieskeeps toolchain behaviour consistent.components/craftmypdf/package.json (1)
15-17: Consider adding@pipedream/typesunderdevDependenciesfor parity with other componentsMost components in this PR now declare
@pipedream/typesindevDependenciesto enable autocompletion / type-checking during local development.craftmypdfis the only updated package that still misses it.
Adding it keeps the workspace configuration consistent across all components."dependencies": { "@pipedream/platform": "^3.1.0" + }, + "devDependencies": { + "@pipedream/types": "^0.3.2" }components/yelp/package.json (1)
19-21: Align@pipedream/typesversion with the latest used in the repo (^0.1.6).Other components adopt
^0.1.6, whereas this file adds^0.1.4. Keeping a single version avoids duplicate installs and type mismatches.- "@pipedream/types": "^0.1.4" + "@pipedream/types": "^0.1.6"components/docupilot/package.json (2)
18-20: Outdated@pipedream/platformmajor version (^1.1.0).Running against v1 while other components target v3 may cause incompatibilities when these components are installed together. Recommend upgrading or documenting the constraint.
21-23: Use latest typings (^0.1.6) for consistency.Same rationale as other files – align versions across packages.
- "@pipedream/types": "^0.1.4" + "@pipedream/types": "^0.1.6"components/zoho_assist/package.json (1)
19-21: Bump@pipedream/typesto the shared latest (^0.1.6).Keeps type definitions in lock-step with other components.
- "@pipedream/types": "^0.1.4" + "@pipedream/types": "^0.1.6"components/apitemplate_io/package.json (1)
21-23: Optional: normalise@pipedream/typesversionMost components added
@pipedream/types^0.1.4; this one uses^0.3.2.
If that was intentional (newer typings required) ignore this, otherwise align for consistency.components/jvzoo/package.json (1)
14-17: Consider adding@pipedream/typesfor symmetryWhile not strictly required, most components declare
@pipedream/typesindevDependenciesto aid IDEs and CI type-checking.
Adding it here will keep tooling behavior uniform across all packages."dependencies": { "@pipedream/platform": "^3.1.0" + }, + "devDependencies": { + "@pipedream/types": "^0.3.2" }components/kucoin_futures/package.json (1)
18-20: Add@pipedream/typesto devDependencies for consistencyOther packages in this PR add the types helper to
devDependencies; omitting it here can break type-checking in IDEs and CI."devDependencies": { + "@pipedream/types": "^0.3.2" }validation-report.json (1)
1-1210: Generated artefact should not live in source — and it’s missing a trailing newline
validation-report.jsonis a bulky, build-generated file that will churn on every run. Keeping it in the repo will create noisy diffs and repo bloat. Consider:
- Add it to
.gitignore(or store underartifacts/and exclude from npm publish).- If you really need it versioned, trim to only the failing entries to reduce size.
- Add the required final newline to satisfy the linter:
@@ - } -] + } +] +
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (84)
components/acelle_mail/package.json(2 hunks)components/affinda/package.json(2 hunks)components/aircall/package.json(2 hunks)components/amplenote/package.json(2 hunks)components/apitemplate_io/package.json(2 hunks)components/azure_storage/package.json(2 hunks)components/baserow/package.json(2 hunks)components/beanstalkapp/package.json(2 hunks)components/beehiiv/package.json(2 hunks)components/buy_me_a_coffee/package.json(2 hunks)components/clientary/package.json(2 hunks)components/clientify/package.json(2 hunks)components/cloudmersive/package.json(2 hunks)components/cloudtables/package.json(2 hunks)components/coassemble/package.json(1 hunks)components/codeq_natural_language_processing_api/package.json(2 hunks)components/concord/package.json(2 hunks)components/craftmypdf/package.json(2 hunks)components/crove_app/package.json(2 hunks)components/currencyscoop/package.json(2 hunks)components/daffy/package.json(2 hunks)components/data_axle_platform/package.json(1 hunks)components/detrack/package.json(2 hunks)components/docupilot/package.json(2 hunks)components/eodhd_apis/package.json(2 hunks)components/expensify/package.json(2 hunks)components/firmao/package.json(2 hunks)components/formatting/package.json(2 hunks)components/getemails/package.json(2 hunks)components/godial/package.json(2 hunks)components/google_my_business/package.json(2 hunks)components/google_tag_manager/package.json(1 hunks)components/h_supertools_analytics_tool/package.json(2 hunks)components/imgur/package.json(2 hunks)components/infinity/package.json(2 hunks)components/ipbase/package.json(2 hunks)components/jvzoo/package.json(2 hunks)components/kanbanflow/package.json(2 hunks)components/kiwihr/package.json(2 hunks)components/kucoin_futures/package.json(1 hunks)components/lemon_squeezy/package.json(2 hunks)components/lettria/package.json(2 hunks)components/listen_notes/package.json(2 hunks)components/lob/package.json(2 hunks)components/mailbluster/package.json(2 hunks)components/mailboxvalidator/package.json(2 hunks)components/mailwizz/package.json(2 hunks)components/mattermost/package.json(2 hunks)components/mediatoolkit/package.json(2 hunks)components/mem/package.json(2 hunks)components/metaphor/package.json(2 hunks)components/nectar_crm/package.json(2 hunks)components/neverbounce/package.json(2 hunks)components/niftyimages/package.json(2 hunks)components/ninox/package.json(2 hunks)components/omnivore/package.json(2 hunks)components/one_ai/package.json(2 hunks)components/onfleet/package.json(2 hunks)components/open_exchange_rates/package.json(2 hunks)components/openai/package.json(2 hunks)components/persistiq/package.json(2 hunks)components/placid/package.json(2 hunks)components/plecto/package.json(2 hunks)components/practitest/package.json(2 hunks)components/pushbullet/package.json(2 hunks)components/qstash/package.json(2 hunks)components/raven_tools/package.json(2 hunks)components/renderform/package.json(2 hunks)components/repuso/package.json(2 hunks)components/resend/package.json(2 hunks)components/reversecontact/package.json(2 hunks)components/rise/package.json(2 hunks)components/rss/package.json(2 hunks)components/signalwire/package.json(2 hunks)components/smaily/package.json(2 hunks)components/square/package.json(2 hunks)components/starshipit/package.json(2 hunks)components/team_up/package.json(2 hunks)components/twitter/package.json(2 hunks)components/workast/package.json(2 hunks)components/yelp/package.json(2 hunks)components/zoho_assist/package.json(2 hunks)components/zoho_catalyst/package.json(2 hunks)validation-report.json(1 hunks)
🧰 Additional context used
🧠 Learnings (5)
📓 Common learnings
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.
📚 Learning: when developing pipedream components, do not add built-in node.js modules like `fs` to `package.json...
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.
Applied to files:
components/amplenote/package.jsoncomponents/imgur/package.jsoncomponents/currencyscoop/package.jsoncomponents/beanstalkapp/package.jsoncomponents/azure_storage/package.jsoncomponents/beehiiv/package.jsoncomponents/pushbullet/package.jsoncomponents/openai/package.jsoncomponents/mailboxvalidator/package.jsoncomponents/signalwire/package.jsoncomponents/clientify/package.jsoncomponents/concord/package.jsoncomponents/google_tag_manager/package.jsoncomponents/ipbase/package.jsoncomponents/repuso/package.jsoncomponents/lettria/package.jsoncomponents/persistiq/package.jsoncomponents/starshipit/package.jsoncomponents/rss/package.jsoncomponents/one_ai/package.jsoncomponents/apitemplate_io/package.jsoncomponents/buy_me_a_coffee/package.jsoncomponents/detrack/package.jsoncomponents/mailwizz/package.jsoncomponents/mattermost/package.jsoncomponents/raven_tools/package.jsoncomponents/practitest/package.jsoncomponents/kiwihr/package.jsoncomponents/acelle_mail/package.jsoncomponents/formatting/package.jsoncomponents/rise/package.jsoncomponents/expensify/package.jsoncomponents/lob/package.jsoncomponents/jvzoo/package.jsoncomponents/omnivore/package.jsoncomponents/metaphor/package.jsoncomponents/resend/package.jsoncomponents/open_exchange_rates/package.jsoncomponents/renderform/package.jsoncomponents/team_up/package.jsoncomponents/neverbounce/package.jsoncomponents/baserow/package.jsoncomponents/mem/package.jsoncomponents/mediatoolkit/package.jsoncomponents/infinity/package.jsoncomponents/kanbanflow/package.jsoncomponents/smaily/package.jsoncomponents/eodhd_apis/package.jsoncomponents/daffy/package.jsoncomponents/zoho_assist/package.jsoncomponents/zoho_catalyst/package.jsoncomponents/kucoin_futures/package.jsoncomponents/cloudmersive/package.jsoncomponents/affinda/package.jsoncomponents/craftmypdf/package.jsoncomponents/aircall/package.jsoncomponents/yelp/package.jsoncomponents/reversecontact/package.jsoncomponents/lemon_squeezy/package.jsoncomponents/coassemble/package.jsoncomponents/docupilot/package.jsoncomponents/mailbluster/package.jsoncomponents/codeq_natural_language_processing_api/package.jsoncomponents/nectar_crm/package.jsoncomponents/qstash/package.jsoncomponents/getemails/package.jsoncomponents/godial/package.jsoncomponents/placid/package.jsonvalidation-report.jsoncomponents/data_axle_platform/package.jsoncomponents/onfleet/package.jsoncomponents/cloudtables/package.jsoncomponents/h_supertools_analytics_tool/package.jsoncomponents/listen_notes/package.jsoncomponents/firmao/package.jsoncomponents/crove_app/package.jsoncomponents/square/package.jsoncomponents/niftyimages/package.jsoncomponents/google_my_business/package.jsoncomponents/twitter/package.jsoncomponents/ninox/package.jsoncomponents/clientary/package.jsoncomponents/workast/package.jsoncomponents/plecto/package.json
📚 Learning: an "object array" type is not yet supported for pipedream props....
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#13961
File: components/fakturoid/actions/create-invoice/create-invoice.mjs:95-99
Timestamp: 2024-10-15T15:07:38.361Z
Learning: An "object array" type is not yet supported for Pipedream props.
Applied to files:
components/amplenote/package.jsoncomponents/openai/package.jsoncomponents/rss/package.jsoncomponents/buy_me_a_coffee/package.jsoncomponents/rise/package.jsoncomponents/expensify/package.jsoncomponents/mediatoolkit/package.jsoncomponents/smaily/package.jsoncomponents/daffy/package.jsoncomponents/zoho_catalyst/package.jsoncomponents/cloudmersive/package.jsoncomponents/reversecontact/package.jsoncomponents/nectar_crm/package.jsoncomponents/twitter/package.jsoncomponents/ninox/package.jsoncomponents/workast/package.json
📚 Learning: "dir" props in pipedream components are hidden in the component form and not user-facing, so they do...
Learnt from: js07
PR: PipedreamHQ/pipedream#17375
File: components/zerobounce/actions/get-validation-results-file/get-validation-results-file.mjs:23-27
Timestamp: 2025-07-01T17:07:48.193Z
Learning: "dir" props in Pipedream components are hidden in the component form and not user-facing, so they don't require labels or descriptions for user clarity.
Applied to files:
components/signalwire/package.jsoncomponents/starshipit/package.jsoncomponents/detrack/package.jsoncomponents/formatting/package.jsoncomponents/renderform/package.jsoncomponents/infinity/package.jsoncomponents/docupilot/package.json
📚 Learning: the `fs` module is a native node.js module and doesn't need to be listed as a dependency in the `pac...
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#13769
File: components/gptzero_detect_ai/package.json:15-18
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `fs` module is a native Node.js module and doesn't need to be listed as a dependency in the `package.json` file.
Applied to files:
components/onfleet/package.json
🪛 GitHub Check: Lint Code Base
validation-report.json
[failure] 1210-1210:
Newline required at end of file but not found
🪛 GitHub Actions: Pull Request Checks
validation-report.json
[error] 1210-1210: ESLint: Newline required at end of file but not found (eol-last).
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: pnpm publish
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
🔇 Additional comments (35)
components/h_supertools_analytics_tool/package.json (1)
15-18: Good call adding@pipedream/platformRuntime SDK is now declared and pinned to the latest major (
^3.1.0).components/mailwizz/package.json (1)
15-18: Ignore SDK Version Alignment & QS Advisory
There is no single “most-used” @pipedream/platform version in the repo—many components intentionally remain on v1.x, v2.0.0, and v3.x—so pinning mailwizz to ^1.4.1 is consistent with other legacy components. Additionally,[email protected]has no known prototype-pollution advisories according to npm’s vulnerability data. No changes required.Likely an incorrect or invalid review comment.
components/azure_storage/package.json (1)
17-18: Verify the necessity of the newfast-xml-parserruntime dependency
fast-xml-parseris now bundled for every execution of the Azure Storage component. If it’s only needed during build-time (e.g., to transform XML examples to JSON), consider moving it todevDependenciesto keep end-user bundles slim.components/zoho_catalyst/package.json (2)
16-22: Good move:@pipedream/typescorrectly shifted todevDependencies
Nothing else to flag in this diff.
20-22: Double-check no runtimeimport "@pipedream/types"remainsIf any
.mjsfiles still import from@pipedream/typesat runtime, the module will be missing after this change.components/cloudtables/package.json (1)
16-18: Confirm the newqsdependency is only used server-side
qsincreases bundle size ~7 kB. If query-string building is trivial,URLSearchParamscan replace it.components/lob/package.json (1)
21-23: 👍@pipedream/typesadded todevDependencies– aligns with project standard
No additional issues spotted.components/beehiiv/package.json (1)
18-23: Out-of-date@pipedream/platformversionPinned at
^1.1.1, which predates many platform features. Unless this component is intentionally locked to 1.x, upgrade to match the3.xbaseline used elsewhere in the PR. Also note the older@pipedream/typesrange (^0.1.4) – consider bumping.components/omnivore/package.json (1)
14-15: Double-checkgraphql-request@^6.0.0compatibility
graphql-requestv6 is ESM-only and requires Node ≥ 18 by default. Ensure the target runtime for Pipedream components matches this requirement; otherwise pin to v5.components/twitter/package.json (1)
18-25: Changes look good – dependency block now follows the new convention
@pipedream/platformis added as a runtime dependency and@pipedream/typesis moved todevDependencies, which matches the pattern adopted across the PR. No red flags here.components/acelle_mail/package.json (1)
12-17: Dependency added, but confirm there’s no need for@pipedream/typesOnly
@pipedream/platformwas introduced. If this component includes TypeScript code, consider adding@pipedream/typesunderdevDependenciesfor editor / build-time support.components/open_exchange_rates/package.json (1)
12-17: LGTM – platform dependency correctly addedThe JSON structure is now valid and the runtime dependency list is minimal.
components/crove_app/package.json (1)
12-17: LGTM – consistent with the repo-wide migration
No issues spotted.components/mattermost/package.json (1)
18-22: Align@pipedream/platformto the repository-wide runtime versionMost components in this PR pin
@pipedream/platformto^3.1.0, while this package still references^1.6.0. A divergent runtime version invites subtle runtime incompatibilities (helpers, auth helpers, prop builders, etc.) and complicates dependency deduplication for users who mix components.- "@pipedream/platform": "^1.6.0" + "@pipedream/platform": "^3.1.0"Please verify the component builds and runs with the unified version before publishing.
components/plecto/package.json (1)
12-18: Missing devDependency for@pipedream/typesIf any source files import
@pipedream/typesfor compile-time helpers (common in recent components), omitting it will breaknpm install --production=falsein local development and CI."dependencies": { "@pipedream/platform": "^3.1.0" }, + "devDependencies": { + "@pipedream/types": "^0.3.0" + }Confirm whether the component actually imports the package, and add it if necessary.
components/buy_me_a_coffee/package.json (1)
3-3: Version bump OK
No issues with incrementing the patch version.components/google_my_business/package.json (1)
3-3: Version bump OK
Patch release is fine.components/neverbounce/package.json (1)
3-3: Version bump OK
Nothing to flag here.components/reversecontact/package.json (1)
3-3: Version bump OK
Patch version looks good.components/aircall/package.json (1)
3-3: Version bump OK
Patch increment approved.components/mailboxvalidator/package.json (1)
18-23: Inconsistent@pipedream/platformmajor version – verify before merge
Most components in this PR adopt@pipedream/platform^3.1.0, but this package still references^1.1.1. Mixing major versions across the monorepo will likely break deduplication and can surface runtime bugs due to API changes between v1 and v3. Confirm whether the mailboxvalidator codebase is truly pinned to v1 APIs or update to^3.1.0for consistency.- "@pipedream/platform": "^1.1.1" + "@pipedream/platform": "^3.1.0"components/mailbluster/package.json (1)
21-25: LGTM – dependency layout follows the new convention
@pipedream/platformis now a runtime dependency and@pipedream/typesmoved todevDependencies, matching the PR objective. No further action needed.components/nectar_crm/package.json (1)
18-23: Upgrade to platform v3 looks correctThe bump from
^1.1.1→^3.1.0and the newdevDependenciesentry align with the repository-wide migration. Nice work.components/starshipit/package.json (1)
15-17: LGTM – dependency added and JSON structure fixedThe
publishConfigblock is now properly closed and the component depends on@pipedream/platform^3.1.0. Looks good.components/yelp/package.json (1)
17-18: Consider upgrading@pipedream/platformto the current major used elsewhere (^3.1.0).Most packages in this PR move to
@pipedream/platform@^3.1.0, but this component is still pinned at^1.2.1. Maintaining multiple major versions inflates install size and increases the risk of runtime incompatibilities between shared utilities. Verify whether this component relies on v1-only APIs; if not, bump to v3 for consistency.components/resend/package.json (1)
18-20: Update@pipedream/platformto^3.1.0for version parity.This package remains on
^1.5.1while siblings move to v3. Confirm whether legacy APIs are required; otherwise bump to avoid fragmentation.components/zoho_assist/package.json (1)
16-18: Platform dependency is behind (^1.5.1vs^3.1.0).Synchronising on a single major reduces maintenance overhead. Validate upgrade feasibility.
components/rise/package.json (1)
19-22: Confirm cross-package alignment on@pipedream/platformmajor versionThis component now pins
@pipedream/platformto^3.1.0, while several sibling packages in the same PR still reference the v1.x line. If these components are executed together in the same Lambda bundle, the mixed major versions may cause duplicate copies of the framework or runtime errors when peer-dependency expectations diverge.Action items
- Verify that all
@pipedream/*packages that will co-exist at runtime target the same major version of@pipedream/platform.- If v3 is the new baseline, upgrade the remaining packages in this PR; otherwise keep this one on v1.x.
components/baserow/package.json (1)
21-22: 👍 ‑ Moving@pipedream/typestodevDependenciesis correctThe type-only package is not needed at runtime; relocating it reduces the production bundle surface.
components/daffy/package.json (1)
15-20: Missingfilesentry and unusualmainpath may break publishUnlike most components that export built artefacts under
dist/, this package declares:"main": "daffy.app.mjs"but has no corresponding
"files": ["dist"](or equivalent) whitelist. NPM will publish the raw source tree unless excluded by.npmignore, and the entry file may not exist at the package root.Please verify:
- The artefact path (
daffy.app.mjsvsdist/app/daffy.app.mjs) is correct post-build.- The
"files"array includes that artefact (or a glob) to avoid shipping extraneous files.components/google_tag_manager/package.json (1)
5-5: Good catch – adding themainentry resolves validation errorsThe absence of
"main"was flagged in the validation report; this addition ensures correct module resolution.components/lemon_squeezy/package.json (1)
18-24: Runtime vs dev dependency split looks good – double-check semver impact
@pipedream/platformis a runtime dependency and@pipedream/typescorrectly sits indevDependencies, so the classification is sound.
However, adding a new runtime dependency can be considered a behaviour-affecting change for downstream users; bumping only the patch version (0.0.3→0.0.4) may be too conservative under semver. If consumers lock exact versions, they now download an extra package at install time.Consider publishing this as a minor (
0.1.0) instead, or verify with the team’s versioning policy.components/coassemble/package.json (2)
10-12: Nice readability tweakSwitching the
filesarray to multi-line format improves diff clarity for future changes. 👍
18-23: Dependency additions OK, but confirm transitive size
@pipedream/platformpulls in axios and friends; if the component already bundles its own HTTP client, you might end up with duplicates. Make sure no redundant copies ship in the final bundle.components/data_axle_platform/package.json (1)
18-23: Comma fix + deps LGTMThe missing comma after
publishConfigpreviously broke JSON; good catch. Dependency split mirrors other components and looks correct.
| "dependencies": { | ||
| "@pipedream/platform": "^1.1.1" | ||
| "@pipedream/platform": "^3.1.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@pipedream/types": "^0.3.2" | ||
| } |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Confirm @pipedream/types is not required at runtime
@pipedream/types was moved to devDependencies, which is the correct place as long as it’s only used for type-checking / build-time tooling.
Please double-check that no runtime import/require of this package exists in the Amplenote component code.
Run a quick search to verify:
🏁 Script executed:
#!/bin/bash
# Expect: zero matches
rg --fixed-strings '@pipedream/types' components/amplenote --glob '!**/*.d.ts'Length of output: 443
Move @pipedream/types into dependencies
This package is imported at runtime in your component code, so it must be available in production:
• components/amplenote/app/amplenote.app.ts
• components/amplenote/actions/create-task/create-task.ts
• components/amplenote/actions/create-note/create-note.ts
Update components/amplenote/package.json accordingly:
"dependencies": {
"@pipedream/platform": "^3.1.0",
+ "@pipedream/types": "^0.3.2"
},
"devDependencies": {
- "@pipedream/types": "^0.3.2"
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "dependencies": { | |
| "@pipedream/platform": "^1.1.1" | |
| "@pipedream/platform": "^3.1.0" | |
| }, | |
| "devDependencies": { | |
| "@pipedream/types": "^0.3.2" | |
| } | |
| "dependencies": { | |
| "@pipedream/platform": "^3.1.0", | |
| "@pipedream/types": "^0.3.2" | |
| }, | |
| "devDependencies": { | |
| } |
🤖 Prompt for AI Agents
In components/amplenote/package.json between lines 18 and 23, the package
@pipedream/types is incorrectly listed under devDependencies but is used at
runtime in the component code. Move @pipedream/types from devDependencies to
dependencies to ensure it is included in the production build and available when
the component runs.
| "dependencies": { | ||
| "@pipedream/platform": "^3.1.0" | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add @pipedream/types to devDependencies for type-safe builds.
Unlike the other updated packages, this component did not add the typings package moved in this PR. If the source imports from @pipedream/types (common in apps), the install will fail at build time.
"@pipedream/platform": "^3.1.0"
+},
+ "devDependencies": {
+ "@pipedream/types": "^0.1.6"
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "dependencies": { | |
| "@pipedream/platform": "^3.1.0" | |
| } | |
| "dependencies": { | |
| "@pipedream/platform": "^3.1.0" | |
| }, | |
| "devDependencies": { | |
| "@pipedream/types": "^0.1.6" | |
| } |
🤖 Prompt for AI Agents
In components/codeq_natural_language_processing_api/package.json around lines 15
to 17, add "@pipedream/types" to the "devDependencies" section to ensure
type-safe builds. This is necessary because the source likely imports from
"@pipedream/types", and without it in devDependencies, the build will fail. Add
the appropriate version of "@pipedream/types" consistent with other packages in
the project.
components/smaily/package.json
Outdated
| "dependencies": { | ||
| "@pipedream/platform": "^1.1.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@pipedream/types": "^0.3.2" | ||
| } |
There was a problem hiding this comment.
Major SDK version lag – update @pipedream/platform
This package still depends on ^1.1.0, whereas the rest of the repo has standardised on the v3 SDK.
The public API changed between v1 and v3 (e.g., auth helpers, this.$send). Shipping different majors side-by-side will very likely break builds for users who rely on shared lock files.
- "@pipedream/platform": "^1.1.0"
+ "@pipedream/platform": "^3.1.0"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "dependencies": { | |
| "@pipedream/platform": "^1.1.0" | |
| }, | |
| "devDependencies": { | |
| "@pipedream/types": "^0.3.2" | |
| } | |
| "dependencies": { | |
| "@pipedream/platform": "^3.1.0" | |
| }, | |
| "devDependencies": { | |
| "@pipedream/types": "^0.3.2" | |
| } |
🤖 Prompt for AI Agents
In components/smaily/package.json between lines 18 and 23, update the dependency
version of "@pipedream/platform" from "^1.1.0" to the latest v3 version used in
the rest of the repo to ensure compatibility. Verify the new version number and
update any related code to accommodate API changes between v1 and v3, such as
auth helpers and this.$send usage, to prevent build breaks due to version
conflicts.
jcortes
moved this from Ready for PR Review
to Ready for QA
in Component (Source and Action) Backlog
|
I'll merge this since there are no components to QA. This is just fixing package dependency patterns |
github-project-automation
bot
moved this from Ready for QA
to Done
in Component (Source and Action) Backlog
package.jsonfiles, mostly@pipedream/platformand@pipedream/types;@pipedream/typestodevDependenciesinstead ofdependencies;@pipedream/platformand@pipedream/typeson all packages being modified in this PR to match the latest versions.Note that since do not currently result in behavior errors in components, we are not updating/publishing any individual components, only the packages, so that they can be properly imported and their dependency chain consistent.
Summary by CodeRabbit
Summary by CodeRabbit