Add camera mismatch banner to dashboard #1921
Conversation
|
Looks good, I'll test when I have a chance. |
|
This is all front-end code. Shouldn't we also involve the back-end, at least to log that there is a conflict? |
|
Yea I agree with Craig. If we could just get a log message, ideally with the camera that should be there, and the camera that is there. This should only happen once, when the camera is initially connected and mismatched. |
photon-core/src/main/java/org/photonvision/vision/processes/VisionSourceManager.java
Outdated
Show resolved
Hide resolved
|
I'm no longer seeing a mismatch banner at all, even if there is a mismatch present. |
|
Can we add some language about how matching is performed using USB port to the banner? |
This is still the case, not quite sure what changed but it's no longer working. |
photon-core/src/main/java/org/photonvision/vision/camera/PVCameraInfo.java
Show resolved
Hide resolved
github-actions
bot
added
frontend
| // First, make sure that nickname is globally unique since we use the nickname | ||
| // in NetworkTables. |
| // FileVisionSources are a bit quirky. They aren't enumerated by the above, but | ||
| // i still want my |
| protected final HashMap<String, CameraConfiguration> disabledCameraConfigs = new HashMap<>(); | ||
|
|
||
| // Set of cameras that where a camera mismatch error was logged | ||
| protected final Set<String> warnedMismatchCameras = Set.of(); |
There was a problem hiding this comment.
Is a Set really the best way to track this? Feels like we should be using a true object instead
| * For file cameras, it checks the uniquePath and name. | ||
| * Note: When changing this function, change the equivalent function within photon-core's VisionSourceManager class | ||
| */ | ||
| export const camerasMatch = (camera1: PVCameraInfo, camera2: PVCameraInfo) => { |
There was a problem hiding this comment.
Does it make sense for this logic to be dulicated now in the backend and frontend?
4 participants
Description
Detects if a camera mismatch is present in any camera and displays a banner in the dashboard for better visibility to the user.
Closes #1920
Meta
Merge checklist: