Build binary+rpm in Docker under the correct OS #201
Merged
+99
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the Dockerfile small when we started I made it simply curl/wget a built-binary from our Github releases page. This will fix the Travis CI failure for PR #200 too.
Now that it will be used in travis-ci tests we need to build the actual code we changed into a Docker container. Secondly, I added debian 8 and 9 builds and made all builds happen in Docker containers of the os they build for.
Lastly, I made the docker container run MCB as non-root by installing the RPM and using the user the RPM creates to run MCB for the container.
'make release' will build docker, centos7 (rpm+bin) and debian 8 and 9 bins: