Skip to content

Conversation

timvaillancourt
Copy link
Contributor

@timvaillancourt timvaillancourt commented Aug 22, 2017

This PR moves the code to adhering to flake8 with these ignored/exception codes (for now):

  1. E221 multiple spaces before operator = because we align equals-signs and dict colons (=/:) in the code.
  2. E241 multiple spaces after ':' = same thing as E221.
  3. E501 line too long = this is valid and should be fixed but one step at a time.

NOTE: "# NOQA" tags are added to our dynamic imports that cause flake8 issues. Due to the way we dynamically load our modules I don't think this can be avoided. "# NOQA" causes flake8 to ignore the problem in these cases.

The fixes in this PR were mostly:

  1. Functions/modules imported but not used.
  2. Variables set but not used.
  3. Whitespace issues.
  4. In a few cases Error-types used but not imported.
  5. 'if !=' to 'if not' style fixes.

After this is done we can do flake8 checks in travis-ci (after #197 is reviewed/merged)

@dbmurphy dbmurphy merged commit 863a431 into Percona-Lab:master Aug 23, 2017
@timvaillancourt timvaillancourt deleted the flake8_fixes_v0 branch August 23, 2017 15:52
timvaillancourt added a commit that referenced this pull request Sep 1, 2017
dbmurphy added a commit that referenced this pull request Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants