Update instance removal logic on component unmount #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yevdyko
force-pushed
the
update-instance-removal-logic-on-unmount
branch
from
5b447ef to
552c9e9
Compare
jhrtn
reviewed
Mar 21, 2022
Contributor
jhrtn
left a comment
jhrtn
left a comment
There was a problem hiding this comment.
Thanks for the prompt update! I've tested this in my minimal sandbox, the official example and the app I'm using the lib for and it appears to resolve the issue in all cases
Co-authored-by: Joseph Horton <[email protected]>
yevdyko
force-pushed
the
update-instance-removal-logic-on-unmount
branch
from
836256f to
f6c200e
Compare
yevdyko
requested changes
Mar 22, 2022
Contributor
There was a problem hiding this comment.
@jamesrweb I've tested the fix using a minimal sandbox from @jhrtn and everything works as expected.
The only thing that can be improved is the unification of the mentioned variable name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142
Proposed Changes
Additional notes
Please await a review from @jhrtn before merging.
Relates to the #145