Resolve unmounting instance issue #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesrweb
added
bug
enhancement
dependencies
fredrikelmegren
approved these changes
Feb 16, 2022
| }, [props]); | ||
| }, [props, instance]); | ||
|
|
||
| useIsomorphicEffect(() => () => instance?.remove(), []); |
There was a problem hiding this comment.
Haven't had time to test it out, but this here line looks like it'd indeed solve #142 😃
yevdyko
approved these changes
Feb 16, 2022
Contributor
There was a problem hiding this comment.
Thanks for the extra testing @jamesrweb!
Looks good to me 🐑
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #142
Proposed Changes
innerHTMLcontent. This in turn triggers the unmount effect.