Deploy 098 LidoWithdrawalStrategy

[sparrowDom]

Change PRs

• Lido withdraw strategy #2080
• Lido Withdraw Strategy deployment changes #2116

Contracts

Deployment script 098_lido_withdrawal_strategy

LidoWithdrawalStrategyProxy: 0x02087ea54ee7b6421089AE23E7ff6cD506f507f9
LidoWithdrawalStrategy: 0xDbCD3CbF3fb639a2DB5c7950793c5020d7780071

Governance

Proposal transaction: 0xe54380b3b4bf8d4cc505a0abacda4eb28824ac1cfd377cca96b15beeef21ff22
Proposal id: 2626764423234271308388524116226544768850357228938163129912794625401165031109

Reviewer checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.68%. Comparing base (bbb0b28) to head (e173402).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2117      +/-   ##
==========================================
- Coverage   61.28%   59.68%   -1.61%     
==========================================
  Files          66       66              
  Lines        3322     3321       -1     
  Branches      863      862       -1     
==========================================
- Hits         2036     1982      -54     
- Misses       1283     1336      +53     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[naddison36]

@sparrowDom the deployed LidoWithdrawalStrategy contract does not match master. It's missing the late changes from yesterday in PR #2116

Some of the changes are insignificant but one is important as it fixed problems in claimWithdrawals. Specifically, we need to update outstandingWithdrawals without subtracting stEthDust

outstandingWithdrawals += stETHStart;

sol2uml diff 0xDbCD3CbF3fb639a2DB5c7950793c5020d7780071 .,node_modules

[sparrowDom]

thanks for catching this @naddison36, closing the PR, proposal cancelled