Skip to content

Conversation

@naddison36
Copy link
Collaborator

Code Change Checklist

To be completed before internal review begins:

  • The contract code is complete
  • Executable deployment file
  • Fork tests that test after the deployment file runs
  • Unit tests *if needed
  • The owner has done a full checklist review of the code + tests

Internal review:

  • Two approvals by internal reviewers

@github-actions
Copy link

github-actions bot commented Jul 2, 2024

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against 3e6a869

@codecov
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.27%. Comparing base (bbb0b28) to head (3e6a869).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2116      +/-   ##
==========================================
+ Coverage   61.28%   62.27%   +0.98%     
==========================================
  Files          66       66              
  Lines        3322     3321       -1     
  Branches      863      862       -1     
==========================================
+ Hits         2036     2068      +32     
+ Misses       1283     1250      -33     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@naddison36 naddison36 mentioned this pull request Jul 2, 2024
5 tasks
@openzeppelin-code
Copy link

Lido Withdraw Strategy deployment changes

Generated at commit: 3e6a8695f124cc757178e1681933c4d20be02bd6

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
3
3
0
18
42
66
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@sparrowDom
Copy link
Member

thanks for these changes @naddison36. The fork tests failing don't seem to be related to this branch

Copy link
Member

@sparrowDom sparrowDom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sparrowDom sparrowDom merged commit fae1a65 into master Jul 2, 2024
@sparrowDom sparrowDom deleted the nicka/lido-withdraw-strategy2 branch July 2, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants