Setup improvements #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest version of ClassicShell was 4.3.1. There is no reason to display any warning about very old versions (< 2.0.0). Besides, this will remove dependency on version.dll which could be misused for DLL hijacking attack. Fixes Open-Shell#72
There is no need for password protected beta versions.
…e a bit easier) During upgrade from ClassicShell we'll try to terminate ClassicStartMenu.exe as well. So that installer won't complain about files being in use.
XenHat
approved these changes
Aug 18, 2018
|
Not quite the right place to put this in, but just wanted to comment. After my last post half a month ago, I decided to finally upgrade. Backed up settings, uninstalled, rebooted, installed v.131 (explorer/start menu). No issues of any kind. Successfully migrated old data (no import needed), immediately started working without an explorer restart (afaik). Now to start testing to see if the issues I suffered with 4.3.1 are fixed.. and if it works with Win10 versions later than 1703 which I'm about to test upgrade to (1803). |
Member
|
@DAOWAce 👍 👍 😉 |
|
Did this fix #76 ? |
Member
|
Edit: NVM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes #72 along the way.