The Installer is Broken

[488GTB]

On my 3 systems, the Classic Shell installer worked fine.
The new OpenShell installer fails.
It cannot terminate explorer.exe processes properly, even when run as Administrator.

The only way I can get OpenShell to install is to Ctl-Alt-Del and manually terminate explorer.exe.

[AveYo]

For clarification, did you use the latest nightly OpenShellSetup_4_4_131?

[coddec]

@488GTB
OpenShellSetup_4_4_131

https://ci.appveyor.com/project/passionate-coder/open-shell-menu/branch/master/artifacts

[gardenman]

Same for me, install is broken on 4.4.131. Only tested in 1 VM so far.
Version 4.4.109 was the same for me. On my desktop, and 2 VMs. I just manually closed them out and ran the install and then manually reopened them if I remember correctly.

More details, with version 4.4.131, it closes Explorer out, leaves a blue screen and acts like it still can't close it out. Eventually gives up and gives error "The setup was unable to automatically close all requested applications. Please ensure that the applications holding files in use are closed before continuing with the installation." ---- I pressed OK and it says "The following applications are using files that need to be updated....." and it lists "Classic Start Menu" and "Windows Explorer". It has the option to "Close the applications" automatically chosen. I hit OK. It gives the same error "The setup was unable to automatically...". Press OK. And it appears to finish installing/copying files. Click Finish button and I'm left with a blank blue screen. Not a BSOD. It's Windows without Explorer running. Can manually run it again with Task Manager. Then I can't access start menu. Spinning circle over button and task bar.

If I wait for the first message then manually close Explorer out, install, then re-run Explorer after setup, then the install works fine and it runs fine afterwards. Can probably reproduce this 10/10 times in a VM. Just did it 3 times in a row.

[488GTB]

Yes. I also had the same problem with 4.4.129 and 4.4.130. Regards

…

On Tue, 21 Aug 2018 at 18:44, AveYo ***@***.***> wrote: For clarification, did you use the latest nightly OpenShellSetup_4_4_131? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#76 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AWQRh9s9lz46A1lj1NnLooiBDDUVwmZ9ks5uS-SUgaJpZM4WFWIp> .

[AveYo]

Can you get this bug fixed, please? It's kinda show-stopper for many, and an annoyance for everybody.

1803 and later versions often do this when trying to kill explorer from installers - UI is closed but a process remains in limbo, preventing the installer from continuing - it will keep trying on a loop.

You know what does not fail? the simple shell non-elevated command taskkill /im explorer.exe /f

Killing the Shell Infrastructure Host would also kill explorer followed by an automatic relaunch so that an explorer window does not appear at the end.

[ge0rdi]

I can replicate the same issue with original ClassicShell too. So it doesn't seem to be related to OpenShell changes (there were just minor cosmetic changes in the installer).

Though, definitely it will be great to fix it somehow.

I'll try to play with it a bit. In worst case add explicit explorer.exe termination and restart.
But this should be really a job of MSI installer. And usually it does the job, but it seems there is some issue that prevents it from successful explorer termination. So I'd like to investigate this.

[thunderpants]

I just installed OpenShellSetup_4_4_131.exe on 1803(fully updated) ,no problems ,installed ok.
Explorer shut down ok until install process finished.

[AveYo]

@thunderpants: the issue is not about when it works, it's about when it fails - and it fails consistently at least 2 out of 10 times in the following scenario: "upgrading from the classic / previous versions" i.e. having ClassicShell / OpenShell already running.

[Ibuprophen]

So the issue looks like the installer doesn't/can't stop all the Classic Shell dependencies before/during the upgrade process of the software to Classic Start.

This is likely, in turn, not able to restart the explorer.exe because of these Classic Shell dependencies are still running.

This is probably resulting in an incomplete upgrade to the Classic Start because of one or more of the Classic Shell dependencies still hooked to the explorer.exe.

I hope I had explained this okay via text... 👍

~Ibuprophen

[Hadden89]

I've seen this behaviour in several MSI installers. So worth forcing a terminate-and-restart explorer in the setup ;)

[XenHat]

Looks fixed to me. Just installed it on a clean Windows install

[Ibuprophen]

It looks like this issue has been resolved...

I'm going to close this issue then. 👌

~Ibuprophen