Skip to content

arbitrum: Extend ArbitrumChainParams with uncompressed batch size #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

arbitrum: Extend ArbitrumChainParams with uncompressed batch size #571

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions params/config_arbitrum.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ type ArbitrumChainParams struct {
GenesisBlockNum uint64
MaxCodeSize uint64 `json:"MaxCodeSize,omitempty"` // Maximum bytecode to permit for a contract. 0 value implies params.DefaultMaxCodeSize
MaxInitCodeSize uint64 `json:"MaxInitCodeSize,omitempty"` // Maximum initcode to permit in a creation transaction and create instructions. 0 value implies params.DefaultMaxInitCodeSize
MaxUncompressedBatchSize uint64 `json:"MaxUncompressedBatchSize,omitempty"`
Copy link
Member

@Tristan-Wilson Tristan-Wilson Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chains that don't have MaxUncompressedBatchSize set already will initialize it to zero which causes a backwards incompatibility issue. I'd suggest accessing MaxUncompressedBatchSize through a ChainConfig accessor method like we have below and setting a default there to the original value if MaxUncompressedBatchSize == 0. I think it means you'll need to pass around a ChainConfig instead of an ArbitrumChainParams object.

}

func (c *ChainConfig) IsArbitrum() bool {
Expand Down
Loading