arbitrum: Extend ArbitrumChainParams with uncompressed batch size #571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmikolajczyk41
changed the title
joshuacolvin0
changed the title
Tristan-Wilson
requested changes
Nov 7, 2025
| GenesisBlockNum uint64 | ||
| MaxCodeSize uint64 `json:"MaxCodeSize,omitempty"` // Maximum bytecode to permit for a contract. 0 value implies params.DefaultMaxCodeSize | ||
| MaxInitCodeSize uint64 `json:"MaxInitCodeSize,omitempty"` // Maximum initcode to permit in a creation transaction and create instructions. 0 value implies params.DefaultMaxInitCodeSize | ||
| MaxUncompressedBatchSize uint64 `json:"MaxUncompressedBatchSize,omitempty"` |
Member
There was a problem hiding this comment.
Chains that don't have MaxUncompressedBatchSize set already will initialize it to zero which causes a backwards incompatibility issue. I'd suggest accessing MaxUncompressedBatchSize through a ChainConfig accessor method like we have below and setting a default there to the original value if MaxUncompressedBatchSize == 0. I think it means you'll need to pass around a ChainConfig instead of an ArbitrumChainParams object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
companion PR: OffchainLabs/nitro#3947
part of NIT-3121