Skip to content

Add support for custom certificate key types via environment variables #4762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add support for custom certificate key types via environment variables #4762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions backend/internal/certificate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,6 +857,13 @@ const internalCertificate = {
certificate.domain_names.join(','),
];

if (process.env.CERT_KEY_TYPE) {
args.push('--key-type', process.env.CERT_KEY_TYPE);
}
if (process.env.CERT_ELLIPTIC_CURVE) {
args.push('--elliptic-curve', process.env.CERT_ELLIPTIC_CURVE);
}

const adds = internalCertificate.getAdditionalCertbotArgs(certificate.id);
args.push(...adds.args);

Expand Down Expand Up @@ -907,6 +914,13 @@ const internalCertificate = {
dnsPlugin.full_plugin_name,
];

if (process.env.CERT_KEY_TYPE) {
args.push('--key-type', process.env.CERT_KEY_TYPE);
}
if (process.env.CERT_ELLIPTIC_CURVE) {
args.push('--elliptic-curve', process.env.CERT_ELLIPTIC_CURVE);
}

if (hasConfigArg) {
args.push(`--${dnsPlugin.full_plugin_name}-credentials`, credentialsLocation);
}
Expand Down
4 changes: 3 additions & 1 deletion docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ ENV SUPPRESS_NO_CONFIG_WARNING=1 \
NPM_BUILD_VERSION="${BUILD_VERSION}" \
NPM_BUILD_COMMIT="${BUILD_COMMIT}" \
NPM_BUILD_DATE="${BUILD_DATE}" \
NODE_OPTIONS="--openssl-legacy-provider"
NODE_OPTIONS="--openssl-legacy-provider" \
CERT_KEY_TYPE="" \
CERT_ELLIPTIC_CURVE=""

RUN echo "fs.file-max = 65535" > /etc/sysctl.conf \
&& apt-get update \
Expand Down