Add support for custom certificate key types via environment variables #4762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows users to specify custom key types and elliptic curves for SSL certificates through CERT_KEY_TYPE and CERT_ELLIPTIC_CURVE environment variables. This enables support for ECDSA P-256 certificates and other key types. When these environment variables are empty or not set, the current default behavior is preserved, ensuring backward compatibility. The environment variables are passed as arguments to certbot when generating or renewing certificates for both HTTP and DNS challenges.
mz2
force-pushed
the
feature/custom-cert-key-types
branch
from
3e7bb81 to
2154fe5
Compare
|
Docker Image for build 2 is available on DockerHub: Note Ensure you backup your NPM instance before testing this image! Especially if there are database changes. Warning Changes and additions to DNS Providers require verification by at least 2 members of the community! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for custom certificate key types through
CERT_KEY_TYPEandCERT_ELLIPTIC_CURVEenvironment variables, optionally also passed to the Dockerfile, to enables ECDSA P-256 certificates and other key types beyond the default.Maintains backward compatibility when environment variables are empty or not set (i.e. no impact to current behaviour when the vars are not set).