Skip to content

Fix promises sometimes not resolved #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2017
Merged

Fix promises sometimes not resolved #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46f4b28
Fix promises sometimes not resolved
Aug 22, 2017
5d0eee2
Bump to 0.4.9
Aug 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions IOSDeviceLib/IOSDeviceLib.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1294,6 +1294,7 @@ int main()
{
#ifdef _WIN32
_setmode(_fileno(stdout), _O_BINARY);
_setmode(_fileno(stderr), _O_BINARY);

if (load_dlls())
{
Expand Down
10 changes: 1 addition & 9 deletions message-unpack-stream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,22 +40,14 @@ exports.MessageUnpackStream = class MessageUnpackStream extends stream.Transform
this.push(messageBuffer);
this._endUnpackingMessages(done);
}
} else if (this._unfinishedMessage.length && data.length >= HeaderSize) {
} else {
// Append the new data to the unfinished message and try to unpack again.
const concatenatedMessage = Buffer.concat([this._unfinishedMessage, data]);

// Clear the unfinished message buffer.
this._unfinishedMessage = new Buffer(0);
this._transform(concatenatedMessage);
this._endUnpackingMessages(done);
} else {
// While debugging the data here contains one character - \0, null or 0.
// I think we get here when the Node inner buffer for the data of the data event
// is filled with data and the last symbol is a part of the length header of the next message.
// That's why we need this concat.
// This code is tested with 10 000 000 messages in while loop.
this._unfinishedMessage = Buffer.concat([this._unfinishedMessage, data]);
this._endUnpackingMessages(done);
}
}

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ios-device-lib",
"version": "0.4.8",
"version": "0.4.9",
"description": "",
"types": "./typings/ios-device-lib.d.ts",
"main": "index.js",
Expand Down