Fix promises sometimes not resolved #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
approved these changes
Aug 23, 2017
rosen-vladimirov
added a commit
that referenced
this pull request
Jan 15, 2019
The `message-unpack-stream` parses messages incorrectly in case a message with length less than Header length (4) is received - this leads to indefinite recursion. The problem has been introduced in #24 which was fixing another issue - when the length of the new message is less than the buffer header and there's something in the `_unfinishedMessage`. To resolve the issue, get the previous logic and improve the check - in case we have partial message from the previous time, just add the current message to it and get in the recursion. In case we do not have previous message and current data is less than 4 bytes, just put it in the `_unfinishedMessage` and wait for new data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
In the cases where we end up in the deleted
elsestatement we do not call_transformrecursively, which leads to the fact that the initial promise is never resolved.One can end up in the deleted
elseblock ifstdoutorstderris set to_O_TEXTmode and a message is printed which is exactly 10 symbols on Windows. Any message on a_O_TEXTbuffer has its line feeds replaced with a carriage-return line feed pair. Due to the fact that the number 10 represents the ASCII code for a line feed we are liable to error in that way.Note that the
stderrpipe is currently unused in the production code, so there's no need to rebuild the binaries prior to publishing a new version of the library.Ping @rosen-vladimirov @TsvetanMilanov