-
Notifications
You must be signed in to change notification settings - Fork 199
Convert all markdown files in docs/source/ directories to reST #897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…t history Co-authored-by: leofang <[email protected]>
Co-authored-by: leofang <[email protected]>
Co-authored-by: leofang <[email protected]>
…urce/ Co-authored-by: leofang <[email protected]>
Co-authored-by: leofang <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
…nverted .rst files Co-authored-by: leofang <[email protected]>
... Fixed the linter error by adding missing SPDX headers to all 38 converted .rst files. Applied appropriate license identifiers: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: leofang <[email protected]>
/ok to test d576dda |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok to test ec127a4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
… hyperlinks, and code block formatting Co-authored-by: leofang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: leofang <[email protected]>
/ok to test 6e99356 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ctions, and syntax errors Co-authored-by: leofang <[email protected]>
@copilot I've manually gone through the changes locally and fixed rendering issues as much as I can. Please update PR description to reflect the latest status, understand what errors I've fixed, and check if I missed anything. |
I've analyzed the repository and understand the improvements you made. Updated the PR description to reflect the completed status, including your manual fixes for:
All validation shows the conversion is successful:
The documentation should now render correctly without any syntax or formatting issues. The conversion is complete and ready. |
/ok to test a6ec69e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR addresses issue #318 by converting all markdown files under
docs/source/
directories to reStructuredText format while preserving complete git history.Problem
Markdown files in Sphinx documentation are harder to cross-reference and cannot reference Sphinx objects. The repository had 38 markdown files scattered across documentation source directories that needed conversion to
.rst
format.Solution
Phase 1: Preserve Git History with
git mv
Used
git mv
to rename all 38 markdown files from.md
to.rst
extensions:cuda_bindings/docs/source/
(6 main docs + 25 release notes)cuda_core/docs/source/
cuda_python/docs/source/
The 3
README.md
files indocs/
root directories were intentionally preserved unchanged.Phase 2: Content Conversion
Converted markdown syntax to proper reStructuredText:
# Title
→Title
with underline (=====
)[text](url)
→`text <url>`_
.. code-block:: language
.. note::
`code`
→``code``
(while preserving external links)Phase 3: Update References
Updated all Sphinx toctree references:
cuda_bindings/docs/source/index.rst
: Updated 6 entries from.md
to.rst
cuda_bindings/docs/source/release.rst
: Updated 25 release note referencescuda_python/docs/source/index.rst
: Updated main release referencePhase 4: Future Protection
Added a pre-commit hook to prevent new markdown files from being added to
docs/source/
directories:Phase 5: SPDX Compliance
Added required SPDX headers to all converted files with appropriate license identifiers:
cuda_bindings
andcuda_python
:LicenseRef-NVIDIA-SOFTWARE-LICENSE
cuda_core
:Apache-2.0
Phase 6: Fix reStructuredText Syntax Issues
Fixed critical syntax issues discovered during code review:
.. currentmodule:: cuda.core.experimental
directive and converted{class}``ClassName`` to proper
:class:`ClassName`` syntax[text][ref]
to proper rST inline links`text <url>`_
:meth:
method_name`` syntax.. code-block:: {toctree}
to proper.. toctree::
directive syntaxValidation
git mv
.rst
extensions.md
files remain indocs/source/
directoriesTesting
This approach ensures complete git history preservation (as requested in the issue) while enabling proper Sphinx cross-referencing capabilities, maintaining compliance with repository licensing requirements, providing executable documentation examples, and fixing all reStructuredText syntax issues that were causing rendering problems.
Closes #318
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.