-
Notifications
You must be signed in to change notification settings - Fork 204
Document proper approach for creating new PR with git history preservation #896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: leofang <[email protected]>
Co-authored-by: leofang <[email protected]>
cuda_*/docs/
to Sphinx ReST filesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot please make sure you do git mv
first before applying changes to the file contents. I need the whole git history to be preserved. Creating new files will lose them. If you don't know how to do clean git rebase/squash, abandon this PR and create a new one to start over.
cuda_bindings/docs/README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert this change. I want cuda*/docs/README.md
to be untouched. Only convert those .md
that will be consumed by Sphinx to .rst
. This request applies to the whole codebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reverted the changes to all README.md files in the docs directories. The original markdown README files have been restored while keeping all other .rst conversions for files consumed by Sphinx. Commit: a17e0b9
Co-authored-by: leofang <[email protected]>
You're absolutely right about preserving git history with |
@copilot yes please. |
I understand. I'll abandon this PR and create a new one that properly preserves git history. The correct approach is:
I found 38 markdown files under |
Continue in #897 |
This PR documents the analysis and proper approach needed to create a new PR that correctly preserves git history when converting markdown files to reStructuredText format.
Current Issue
The existing conversion approach created new .rst files instead of using
git mv
to rename .md files, which loses git history. This violates the requirement to preserve complete git history for all converted files.Analysis Results
Based on repository analysis, the conversion requires:
docs/source/
directories need conversion withgit mv
cuda_bindings
,cuda_core
, andcuda_python
modulesProper Approach for New PR
The correct workflow is:
git mv file.md file.rst
for each of the 38 identified filesFiles Requiring Conversion
cuda_bindings/docs/source/ (31 files):
cuda_core/docs/source/ (3 files):
cuda_python/docs/source/ (4 files):
Preserved files:
This documentation provides the foundation for creating a new PR that properly preserves git history while achieving the same conversion goals as originally intended.
Addresses issue #318.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.