Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Nov 16, 2025

waive failed cases.

Summary by CodeRabbit

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251116_LLM_FUNCTION_TEST_1647 branch from ffe55a4 to 466acc9 Compare November 17, 2025 02:32
@xinhe-nv xinhe-nv marked this pull request as ready for review November 17, 2025 02:36
@xinhe-nv
Copy link
Collaborator Author

/bot run

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 17, 2025

📝 Walkthrough

Walkthrough

Two test files were modified: a decorator was added to a test function in the serve test suite, and multiple skip entries were appended to the integration test waiver list to exclude specific test cases from execution across various configurations.

Changes

Cohort / File(s) Summary
Test decorator
tests/integration/defs/examples/serve/test_serve.py
Added @skip_post_blackwell decorator to the test_extra_llm_api_options test function
Test waivers
tests/integration/test_lists/waives.txt
Expanded skip entries across multiple test suites and configurations (e.g., sm100 path, qwen/llama example tests)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single decorator addition to one test function is a straightforward, low-risk change
  • Waiver list expansion is repetitive and configuration-based with no logic modifications

Possibly related PRs

Suggested reviewers

  • crazydemo
  • jieli-matrix
  • LarryXFly

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is minimal and lacks required sections from the template. It does not include detailed explanation of the issue, test coverage information, or a completion checklist. Expand the description to include: the issue being addressed, solution explanation, test coverage details, and completion of the PR checklist as specified in the template.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly indicates the main change: adding failed test cases to waives.txt file. It follows the required format and specifically describes what is being done.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 86cfb3e and 466acc9.

📒 Files selected for processing (2)
  • tests/integration/defs/examples/serve/test_serve.py (1 hunks)
  • tests/integration/test_lists/waives.txt (2 hunks)
🧰 Additional context used
🧠 Learnings (9)
📓 Common learnings
Learnt from: tongyuantongyu
Repo: NVIDIA/TensorRT-LLM PR: 7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.
Learnt from: EmmaQiaoCh
Repo: NVIDIA/TensorRT-LLM PR: 7370
File: tests/unittest/trt/model_api/test_model_quantization.py:24-27
Timestamp: 2025-08-29T14:07:45.863Z
Learning: In TensorRT-LLM's CI infrastructure, pytest skip markers (pytest.mark.skip) are properly honored even when test files have __main__ blocks that call test functions directly. The testing system correctly skips tests without requiring modifications to the __main__ block execution pattern.
Learnt from: nvpohanh
Repo: NVIDIA/TensorRT-LLM PR: 7478
File: tests/unittest/_torch/modeling/test_modeling_llama_min_latency.py:286-308
Timestamp: 2025-09-03T13:16:38.028Z
Learning: In test files, temporary monkey-patches for upstream bugs can be kept simple when they are explicitly intended to be removed soon, rather than investing effort in making them more robust.
📚 Learning: 2025-09-17T02:48:52.732Z
Learnt from: tongyuantongyu
Repo: NVIDIA/TensorRT-LLM PR: 7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-08-26T09:49:04.956Z
Learnt from: pengbowang-nv
Repo: NVIDIA/TensorRT-LLM PR: 7192
File: tests/integration/test_lists/test-db/l0_dgx_b200.yml:56-72
Timestamp: 2025-08-26T09:49:04.956Z
Learning: In TensorRT-LLM test configuration files, the test scheduling system handles wildcard matching with special rules that prevent duplicate test execution even when the same tests appear in multiple yaml files with overlapping GPU wildcards (e.g., "*b200*" and "*gb200*").

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-07-28T17:06:08.621Z
Learnt from: moraxu
Repo: NVIDIA/TensorRT-LLM PR: 6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.

Applied to files:

  • tests/integration/test_lists/waives.txt
  • tests/integration/defs/examples/serve/test_serve.py
📚 Learning: 2025-09-09T09:40:45.658Z
Learnt from: fredricz-20070104
Repo: NVIDIA/TensorRT-LLM PR: 7645
File: tests/integration/test_lists/qa/llm_function_core.txt:648-648
Timestamp: 2025-09-09T09:40:45.658Z
Learning: In TensorRT-LLM test lists, it's common and intentional for the same test to appear in multiple test list files when they serve different purposes (e.g., llm_function_core.txt for comprehensive core functionality testing and llm_function_core_sanity.txt for quick sanity checks). This duplication allows tests to be run in different testing contexts.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-08-29T14:07:45.863Z
Learnt from: EmmaQiaoCh
Repo: NVIDIA/TensorRT-LLM PR: 7370
File: tests/unittest/trt/model_api/test_model_quantization.py:24-27
Timestamp: 2025-08-29T14:07:45.863Z
Learning: In TensorRT-LLM's CI infrastructure, pytest skip markers (pytest.mark.skip) are properly honored even when test files have __main__ blocks that call test functions directly. The testing system correctly skips tests without requiring modifications to the __main__ block execution pattern.

Applied to files:

  • tests/integration/test_lists/waives.txt
  • tests/integration/defs/examples/serve/test_serve.py
📚 Learning: 2025-08-06T13:58:07.506Z
Learnt from: galagam
Repo: NVIDIA/TensorRT-LLM PR: 6487
File: tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_bench.py:1-12
Timestamp: 2025-08-06T13:58:07.506Z
Learning: In TensorRT-LLM, test files (files under tests/ directories) do not require NVIDIA copyright headers, unlike production source code files. Test files typically start directly with imports, docstrings, or code.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-08-15T06:46:53.813Z
Learnt from: eopXD
Repo: NVIDIA/TensorRT-LLM PR: 6767
File: cpp/tensorrt_llm/batch_manager/kvCacheManager.cpp:0-0
Timestamp: 2025-08-15T06:46:53.813Z
Learning: In the TensorRT-LLM KV cache manager, SWA (Sliding Window Attention) combined with beam search is currently in a broken/non-functional state and is planned for future rework. During preparatory refactoring phases, code related to SWA+beam search may intentionally remain in a non-working state until the broader rework is completed.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-08-18T08:42:02.640Z
Learnt from: samuellees
Repo: NVIDIA/TensorRT-LLM PR: 6974
File: tensorrt_llm/serve/scripts/benchmark_dataset.py:558-566
Timestamp: 2025-08-18T08:42:02.640Z
Learning: In TensorRT-LLM's RandomDataset (tensorrt_llm/serve/scripts/benchmark_dataset.py), when using --random-token-ids option, sequence length accuracy is prioritized over semantic correctness for benchmarking purposes. The encode/decode operations should use skip_special_tokens=True and add_special_tokens=False to ensure exact target token lengths.

Applied to files:

  • tests/integration/test_lists/waives.txt
🪛 Ruff (0.14.4)
tests/integration/defs/examples/serve/test_serve.py

96-96: Undefined name skip_post_blackwell

(F821)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (1)
tests/integration/test_lists/waives.txt (1)

423-424: LGTM!

The new skip entries are properly formatted with bug references and align with the PR objective to waive failed test cases.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24703 [ run ] triggered by Bot. Commit: 466acc9

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24703 [ run ] completed with state FAILURE. Commit: 466acc9

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251116_LLM_FUNCTION_TEST_1647 branch 2 times, most recently from aa3582f to bcf0171 Compare November 17, 2025 03:06
@xinhe-nv
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24712 [ run ] triggered by Bot. Commit: bcf0171

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24712 [ run ] completed with state FAILURE. Commit: bcf0171

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251116_LLM_FUNCTION_TEST_1647 branch from bcf0171 to 1250b3e Compare November 17, 2025 05:30
@xinhe-nv
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24727 [ run ] triggered by Bot. Commit: 1250b3e

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24727 [ run ] completed with state FAILURE. Commit: 1250b3e

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251116_LLM_FUNCTION_TEST_1647 branch from 1250b3e to 9fb95a0 Compare November 18, 2025 01:27
Signed-off-by: xinhe-nv <[email protected]>
Signed-off-by: Xin He (SW-GPU) <[email protected]>
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251116_LLM_FUNCTION_TEST_1647 branch from 9fb95a0 to 3e19c87 Compare November 18, 2025 01:45
@xinhe-nv xinhe-nv enabled auto-merge (squash) November 18, 2025 01:45
@xinhe-nv
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24821 [ run ] triggered by Bot. Commit: 3e19c87

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24821 [ run ] completed with state SUCCESS. Commit: 3e19c87
/LLM/main/L0_MergeRequest_PR pipeline #18733 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24954 [ reuse-pipeline ] triggered by Bot. Commit: eeaaaf0

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24954 [ reuse-pipeline ] completed with state SUCCESS. Commit: eeaaaf0
Reusing PR_Github #24821 for commit eeaaaf0

@xinhe-nv xinhe-nv merged commit 35658ea into NVIDIA:main Nov 19, 2025
5 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20251116_LLM_FUNCTION_TEST_1647 branch November 19, 2025 01:54
lkomali pushed a commit to lkomali/TensorRT-LLM that referenced this pull request Nov 19, 2025
Signed-off-by: xinhe-nv <[email protected]>
Signed-off-by: Xin He (SW-GPU) <[email protected]>
Signed-off-by: lkomali <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants