Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Nov 3, 2025

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Updated test infrastructure to skip certain test scenarios, including fp8 blockscale variants, OpenAI harmony, and multimodal quickstart scenarios. No functional changes to runtime behavior.

@xinhe-nv xinhe-nv marked this pull request as ready for review November 3, 2025 06:17
@xinhe-nv xinhe-nv enabled auto-merge (squash) November 3, 2025 06:17
@xinhe-nv
Copy link
Collaborator Author

xinhe-nv commented Nov 3, 2025

/bot run --skip-test

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 3, 2025

📝 Walkthrough

Walkthrough

This PR adds SKIP entries to the test waives list for failing integration tests, including fp8_blockscale variants, OpenAI harmony, and multimodal quickstart scenarios. No functional code changes are introduced.

Changes

Cohort / File(s) Summary
Test Waiver Updates
tests/integration/test_lists/waives.txt
Added multiple SKIP entries for failing integration tests covering fp8_blockscale variants, OpenAI harmony, and multimodal quickstart scenarios

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Verify test names are correctly formatted and spelled
  • Confirm entries follow existing waives.txt formatting convention

Possibly related PRs

Suggested reviewers

  • crazydemo
  • jieli-matrix
  • LarryXFly

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description provided is "waive failed cases." — a single, vague sentence that fails to meet the template requirements. The description is largely incomplete, missing critical sections including: a detailed explanation of the issue and solution in the Description section, a Test Coverage section listing relevant tests that safeguard the changes, and the PR Checklist section confirming review of coding guidelines and other requirements. The generic phrasing provides no context about which specific test cases are being waived or why, leaving reviewers with insufficient information to understand the PR's purpose and scope. The description should be expanded to include a proper Description section explaining which failed cases are being waived and the reason for waiving them, a Test Coverage section documenting the relevant tests, and a completed PR Checklist confirming adherence to coding guidelines and repository standards. Consider using the CodeRabbit AI title generation feature mentioned in the template to help complete the description more thoroughly.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "[None][chore] Add failed cases into waives.txt" clearly and directly summarizes the main change in the changeset. The title follows the required template format with an appropriate ticket reference and type indicator. It accurately reflects that the modification is adding entries to the waives.txt file, which aligns with the raw summary showing additions to tests/integration/test_lists/waives.txt. The title is concise, specific, and would allow a teammate to understand the primary change when scanning commit history.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b4d17d1 and 5ccc056.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt (1 hunks)
🧰 Additional context used
🧠 Learnings (7)
📓 Common learnings
Learnt from: tongyuantongyu
Repo: NVIDIA/TensorRT-LLM PR: 7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.
Learnt from: EmmaQiaoCh
Repo: NVIDIA/TensorRT-LLM PR: 7370
File: tests/unittest/trt/model_api/test_model_quantization.py:24-27
Timestamp: 2025-08-29T14:07:45.863Z
Learning: In TensorRT-LLM's CI infrastructure, pytest skip markers (pytest.mark.skip) are properly honored even when test files have __main__ blocks that call test functions directly. The testing system correctly skips tests without requiring modifications to the __main__ block execution pattern.
📚 Learning: 2025-09-17T02:48:52.732Z
Learnt from: tongyuantongyu
Repo: NVIDIA/TensorRT-LLM PR: 7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-09-09T09:40:45.658Z
Learnt from: fredricz-20070104
Repo: NVIDIA/TensorRT-LLM PR: 7645
File: tests/integration/test_lists/qa/llm_function_core.txt:648-648
Timestamp: 2025-09-09T09:40:45.658Z
Learning: In TensorRT-LLM test lists, it's common and intentional for the same test to appear in multiple test list files when they serve different purposes (e.g., llm_function_core.txt for comprehensive core functionality testing and llm_function_core_sanity.txt for quick sanity checks). This duplication allows tests to be run in different testing contexts.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-08-29T14:07:45.863Z
Learnt from: EmmaQiaoCh
Repo: NVIDIA/TensorRT-LLM PR: 7370
File: tests/unittest/trt/model_api/test_model_quantization.py:24-27
Timestamp: 2025-08-29T14:07:45.863Z
Learning: In TensorRT-LLM's CI infrastructure, pytest skip markers (pytest.mark.skip) are properly honored even when test files have __main__ blocks that call test functions directly. The testing system correctly skips tests without requiring modifications to the __main__ block execution pattern.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-07-22T08:33:49.109Z
Learnt from: yiqingy0
Repo: NVIDIA/TensorRT-LLM PR: 5198
File: jenkins/mergeWaiveList.py:0-0
Timestamp: 2025-07-22T08:33:49.109Z
Learning: In the TensorRT-LLM waive list merging system, removed lines are always located at the end of the merge waive lists, which is why the mergeWaiveList.py script uses reverse traversal - it's an optimization for this specific domain constraint.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-07-28T17:06:08.621Z
Learnt from: moraxu
Repo: NVIDIA/TensorRT-LLM PR: 6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-08-26T09:49:04.956Z
Learnt from: pengbowang-nv
Repo: NVIDIA/TensorRT-LLM PR: 7192
File: tests/integration/test_lists/test-db/l0_dgx_b200.yml:56-72
Timestamp: 2025-08-26T09:49:04.956Z
Learning: In TensorRT-LLM test configuration files, the test scheduling system handles wildcard matching with special rules that prevent duplicate test execution even when the same tests appear in multiple yaml files with overlapping GPU wildcards (e.g., "*b200*" and "*gb200*").

Applied to files:

  • tests/integration/test_lists/waives.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (1)
tests/integration/test_lists/waives.txt (1)

400-404: All changes follow established patterns.

The five new test waiver entries (lines 400–404) consistently follow the existing format, reference bug trackers appropriately, and are correctly appended to the end of the file. These changes align with the PR's goal to waive failing test cases.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23346 [ run ] triggered by Bot. Commit: 5ccc056

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251103_LLM_FUNCTION_TEST_1584 branch 2 times, most recently from f88a97e to 1cdb2c7 Compare November 3, 2025 06:50
Signed-off-by: Xin He (SW-GPU) <[email protected]>
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251103_LLM_FUNCTION_TEST_1584 branch from 1cdb2c7 to fe429d4 Compare November 3, 2025 08:51
@tensorrt-cicd
Copy link
Collaborator

PR_Github #23346 [ run ] completed with state SUCCESS. Commit: 5ccc056
/LLM/main/L0_MergeRequest_PR pipeline #17591 (Partly Tested) completed with status: 'SUCCESS'

@xinhe-nv
Copy link
Collaborator Author

xinhe-nv commented Nov 3, 2025

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23367 [ reuse-pipeline ] triggered by Bot. Commit: fe429d4

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23367 [ reuse-pipeline ] completed with state SUCCESS. Commit: fe429d4
Reusing PR_Github #23346 (Partly Tested) for commit fe429d4

@xinhe-nv xinhe-nv merged commit 6454045 into NVIDIA:main Nov 3, 2025
5 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20251103_LLM_FUNCTION_TEST_1584 branch November 3, 2025 09:22
fredricz-20070104 pushed a commit to fredricz-20070104/TensorRT-LLM that referenced this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants