Skip to content

Conversation

@huguesdevimeux
Copy link
Member

@huguesdevimeux huguesdevimeux commented Oct 19, 2020

Hot fix for set_test_scene, which was broken by #532.

We need a test for this, that's why it's WIP.

close #571

@huguesdevimeux
Copy link
Member Author

In fact I'm not sure how to test it and whether it should be so.
Because testing this is basically testing scene.render, and all the rendering process.

@huguesdevimeux huguesdevimeux added the pr:easy review There is nothing particular (i.e, it's about a general/small thing) to know for review! label Oct 21, 2020
@huguesdevimeux huguesdevimeux marked this pull request as ready for review October 21, 2020 19:05
Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kolibril13
Copy link
Member

I don't understand these lines

 assert not np.all(
        data == np.array([0, 0, 0, 255])
    ), f"Control data generated for {str(scene)} only contains empty pixels."
    assert data.shape == (480, 854, 4)

completely.
However, I think it is important to merge this as soon as possible, as other prs really depend on this one (including the new one #580), and then we can come back to discuss how we want to test this in a future pr.

@kolibril13 kolibril13 merged commit 87e72b6 into ManimCommunity:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:easy review There is nothing particular (i.e, it's about a general/small thing) to know for review!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fixing set_test_scene from graphical_units.py

3 participants