Miscellaneous Scene-Caching Optimisations and Bugfixes. #315

huguesdevimeux · 2020-08-17T07:05:45Z

MARKED AS DRAFT BUT THE PR IS DONE.
As we don't have yet tests for videos, I prefer not to merge this right now and wait to have tests. I make this PR if anyone was annoyed by #302, so one can use this branch.

List of Changes (UP TO DATE)

Fixes:
- Fixes Unable to use AnimatedStreamLines : Scene-caching Bug (circular reference) #302 by checking if an object has not been processed before handling it. By doing so, we avoid any circular reference (i.e an object that indirectly refer to itself), causing the JSONEncoder to endlessly try processing the object. We do that recursively for any iterable object.
- Fixes Scene Caching must recognise changes in attributes of objects #320 : Now manim can handle method, and not only functions. It wasn't the case before, sigh
- Fixes Scene-Caching w/ "-" as filename bug : Cannot use Updaters. #348 , by disabling scene caching if - is passed as the filename.
Optimisations:
- Optimization: now the scene caching process does not take care of the scene object, as all of its attributes will be serialized in the different hashes.
- Some docstring, as always.

Explanation for Changes

See above. See the comments and the code for more information.

Testing Status

This won't have test right now as we don't have any way to test videos. When we will (soon, I swear, I'm working on it) I'll write some tests.

Acknowledgement

I have read the Contributing Guidelines

+ some docs

huguesdevimeux · 2020-08-28T10:49:46Z

Could someone run tests locally on this PR ? In GH actions, there is a weird error message

Aathish04 · 2020-08-28T13:38:31Z

Could someone run tests locally on this PR ? In GH actions, there is a weird error message

MacOS Catalina,

E           AssertionError: The frames don't match. TextMobject has been modified.
E           Please ignore if it was intended.
E           First unmatched index is at [229 381]: [  0   0   0 255] != [ 17  17  17 255]

tests/utils/GraphicalUnitTester.py:142: AssertionError

E           AssertionError: The frames don't match. Text has been modified.
E           Please ignore if it was intended.
E           First unmatched index is at [231 398]: [ 36  36  36 255] != [ 35  35  35 255]

tests/utils/GraphicalUnitTester.py:142: AssertionError

E       AssertionError: 
E       assert False
E        +  where False = <function exists at 0x1064eff70>('/private/var/folders/4q/m6kdrdfj1xgf4kjphszzqpp40000gn/T/pytest-of-aathishs/pytest-0/test_logging_to_file0/media_temp/logs/SquareToCircle.log')
E        +    where <function exists at 0x1064eff70> = <module 'posixpath' from '/usr/local/bin/../Cellar/[email protected]/3.8.5/bin/../Frameworks/Python.framework/Versions/3.8/lib/python3.8/posixpath.py'>.exists
E        +      where <module 'posixpath' from '/usr/local/bin/../Cellar/[email protected]/3.8.5/bin/../Frameworks/Python.framework/Versions/3.8/lib/python3.8/posixpath.py'> = os.path

tests/test_logging/test_logging.py:49: AssertionError

The Logging tests fails because no log is created, for some reason. Not sure why the others fail.

Mostly about copys handling.

huguesdevimeux · 2020-08-28T14:05:08Z

Thanks so much @Aathish04

UH ? tests are not working on windows but on Linux ?!

Fix ManimCommunity#348

…o fix-301

leotrs · 2020-09-03T11:16:50Z

manim/__main__.py

@@ -11 +11 @@
 from . import constants, logger, console, file_writer_config


Comment: after this config system is refactored, we should come back here and use tempconfig

What do you mean ? I don't see how tempconfig could be used here. It's not, well, a temporary config (in my mind)

manim/utils/hashing.py

leotrs · 2020-09-03T11:22:27Z

tests/test_hashing.py

+        def __init__(self, a, b):
+            self.a = 2
+            self.b = 3.0
+            self.c = [1, 2, "test", ["nested list"]]
+            self.d = {2: 3, "2": "salut"}
+
+    o = Obj(1, 2)


Nitpick: the init arguments a and b are not used. Was this intentional?

Yes, my mistake. Thanks !

Co-authored-by: Leo Torres <[email protected]>

manim/utils/hashing.py

Co-authored-by: Pg Biel <[email protected]>

…caching-patch

huguesdevimeux · 2020-09-04T14:36:50Z

@PgBiel I adressed all your requests :D

manim/utils/hashing.py

Co-authored-by: Pg Biel <[email protected]>

huguesdevimeux · 2020-09-06T15:08:01Z

@PgBiel I removed all the semi colons, Captain. Feel free to review again.

outdated now

fix 301/scene-caching optimization

9dd0a66

Aathish04 mentioned this pull request Aug 20, 2020

Scene Caching must recognise changes in attributes of objects #320

Closed

PgBiel added the pr:bugfix Bug fix for use in PRs solving a specific issue:bug label Aug 22, 2020

huguesdevimeux mentioned this pull request Aug 26, 2020

Add a tolerance for pixel perfect tests #274

Closed

ManimCommunity deleted a comment from Aathish04 Aug 26, 2020

huguesdevimeux added 7 commits August 28, 2020 10:47

added nested dict with cirular references support

669f988

+ some docs

optimization: now it ignores the scene object

92fc73e

fix ManimCommunity#320

885e0f4

modified verbosity level

813ae0f

added copy error handling

0e953ce

fixed test_logging (maybe)

ce86f7b

captain black

d8a1e14

huguesdevimeux added 3 commits August 28, 2020 15:44

Various improvemens and optimizations,

9b91c6b

Mostly about copys handling.

yes sir I run black I swear sir

0dfe67e

ahem, typo

9530e75

huguesdevimeux mentioned this pull request Aug 29, 2020

Mark (provisionally) test_writing and test_logging as xfails #371

Closed

huguesdevimeux added 2 commits August 29, 2020 14:52

(hopefully) fixed logging test

2095992

Suggestion from the great @aathis

3adc0f4

huguesdevimeux self-assigned this Aug 29, 2020

huguesdevimeux added the test requested Implementation of tests are requested label Aug 29, 2020

huguesdevimeux added this to the PyPI Release 1.0.0 milestone Aug 29, 2020

nilaybhatia mentioned this pull request Aug 30, 2020

Add the Variable class with an example #380

Merged

2 tasks

Aathish04 added the waiting for another pr's merge label Aug 31, 2020

Aathish04 added 4 commits August 31, 2020 10:31

Disable Scene Caching if - is filename.

1f4b236

Fix ManimCommunity#348

Merge branch 'master' into fix-301

524f70e

Import logger from proper place.

0cdefb4

Merge branch 'fix-301' of https://github.com/huguesdevimeux/manim int…

2784621

…o fix-301

Aathish04 added enhancement Additions and improvements in general refactor Refactor or redesign of existing code labels Sep 3, 2020

Aathish04 approved these changes Sep 3, 2020

View reviewed changes

Aathish04 requested review from PgBiel, eulertour, kilacoda-old and leotrs September 3, 2020 11:09

leotrs approved these changes Sep 3, 2020

View reviewed changes

leotrs mentioned this pull request Sep 3, 2020

Scene-Caching w/ "-" as filename bug : Cannot use Updaters. #348

Closed

Fix a typo.

b32634f

Co-authored-by: Leo Torres <[email protected]>

PgBiel requested changes Sep 3, 2020

View reviewed changes

Aathish04 and others added 6 commits September 4, 2020 09:05

Merge branch 'master' into fix-301

3056c0e

Assign suggestions from @PgBiel

3deeac0

suggestion from @leotrs

6fd9ac0

Apply suggestions from code review

2609357

Co-authored-by: Pg Biel <[email protected]>

fixed tests

d32aa9d

Merge branch 'fix-301' of github.com:huguesdevimeux/manim into scene-…

c954820

…caching-patch

PgBiel previously requested changes Sep 4, 2020

View reviewed changes

Hugues Devimeux and others added 3 commits September 4, 2020 17:12

imrpoved code organization

6af65d2

NO COLON NO COLON NO NO COLON NO LOCON NO COLON

2653f6d

Co-authored-by: Pg Biel <[email protected]>

NO COLON NO COLON NO NO COLON NO LOCON NO COLON

174ae36

Co-authored-by: Pg Biel <[email protected]>

naveen521kk mentioned this pull request Sep 5, 2020

Fix File Not Found Error - Github Actions #416

Merged

1 task

Merge branch 'master' into fix-301

c3b8fc2

huguesdevimeux merged commit 5dd7bfe into ManimCommunity:master Sep 8, 2020

huguesdevimeux deleted the fix-301 branch September 8, 2020 11:35

behackl added a commit to behackl/manim that referenced this pull request Sep 9, 2020

set code to empty if it cannot be found (related to ManimCommunity#315)

9a44186

behackl mentioned this pull request Sep 9, 2020

Render videos while building documentation #402

Merged

1 task

		@@ -11 +11 @@
		from . import constants, logger, console, file_writer_config

Miscellaneous Scene-Caching Optimisations and Bugfixes. #315

Miscellaneous Scene-Caching Optimisations and Bugfixes. #315

Uh oh!

Conversation

huguesdevimeux commented Aug 17, 2020 • edited by Aathish04 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

List of Changes (UP TO DATE)

Explanation for Changes

Testing Status

Acknowledgement

Uh oh!

huguesdevimeux commented Aug 28, 2020

Uh oh!

Aathish04 commented Aug 28, 2020

Uh oh!

huguesdevimeux commented Aug 28, 2020

Uh oh!

leotrs Sep 3, 2020

Choose a reason for hiding this comment

Uh oh!

huguesdevimeux Sep 4, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

leotrs Sep 3, 2020

Choose a reason for hiding this comment

Uh oh!

huguesdevimeux Sep 4, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

huguesdevimeux commented Sep 4, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

huguesdevimeux commented Sep 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

huguesdevimeux commented Aug 17, 2020 •

edited by Aathish04

Loading