-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Add the Variable class with an example #380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks @nilaybhatia , another awesome addition! |
|
|
|
@nilaybhatia I believe this is ready for review, no? I'm unmarking as draft. |
|
@leotrs Yes, |
Co-authored-by: Leo Torres <[email protected]>
Co-authored-by: Leo Torres <[email protected]>
…into variable-class
Aathish04
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion, and two nitpicks :)
Co-authored-by: Aathish Sivasubrahmanian <[email protected]>
Co-authored-by: Aathish Sivasubrahmanian <[email protected]>
Co-authored-by: Aathish Sivasubrahmanian <[email protected]>
|
@nilaybhatia Awesome! Could you just add a note in the changelog file mentioning the introduction of this object? I totally forgot to mention it in my first review ! |
|
🎉 🎉 🎉 |
Variableclass for intuitively using continuously updated values #375NOTE: Until #302 is fixed, please use

--disable_cachingto render the video.List of Changes
Variableclass to the file./manim/mobject/numbers.pyVariableExampleclass toexample_scenes/basic.pyMotivation
Discussed here: #375
Explanation for Changes
Using the
Variableclass really makes it easy to use continually updated values. See the example above.Testing Status
I think tests aren't required because the class makes use of updaters and tex, which already have tests.
Further Comments
In the meantime, please feel free to suggest improvements or some more functionalities that can be offered.
TODO:
DecimalNumber(with number of decimal places) or anInteger.Acknowledgement