Porting and drastical rewrite to reach compatibility with 3b1b/manim again
#3107
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| self.shadow = shadow | ||
| # For shaders | ||
| self.render_primitive = render_primitive | ||
| self.gloss = gloss |
Check warning
Code scanning / CodeQL
Overwriting attribute in super-class or sub-class
| and self.mobject == o.mobject | ||
| and self.event_type == o.event_type | ||
| ) | ||
| except Exception: |
Check notice
Code scanning / CodeQL
Empty except
| def duplicate(self, n: int): | ||
| """Returns an :class:`~.OpenGLVGroup` containing ``n`` copies of the mobject.""" | ||
| return self.get_group_class()(*[self.copy() for _ in range(n)]) | ||
| def arrange_to_fit_dim(self, length: float, dim: int, about_edge=ORIGIN): |
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns
| from manim.mobject.opengl.opengl_mobject import ( | ||
| UNIFORM_DTYPE, | ||
| OpenGLMobject, | ||
| OpenGLPoint, | ||
| ) |
Check notice
Code scanning / CodeQL
Cyclic import
| from shutil import copyfile | ||
| from typing import TYPE_CHECKING | ||
|
|
||
| import validators |
Check notice
Code scanning / CodeQL
Unused import
| import configparser | ||
| import copy | ||
| import errno | ||
| import importlib |
Check notice
Code scanning / CodeQL
Unused import
| import copy | ||
| import errno | ||
| import importlib | ||
| import inspect |
Check notice
Code scanning / CodeQL
Unused import
| # if self.consider_points_equals(path[-nppc:], path[-nppc - 1]): | ||
| # path = path[:-nppc] | ||
| # else: | ||
| # break |
Check notice
Code scanning / CodeQL
Commented-out code
| DEGREES: float = TAU / 360 | ||
| """The exchange rate between radians and degrees.""" | ||
|
|
||
| RADIANS: float = 1.0 |
Check notice
Code scanning / CodeQL
Unused global variable
MrDiver
added
breaking changes
| self.embed_exception_mode = embed_exception_mode | ||
| self.embed_error_sound = embed_error_sound | ||
|
|
||
| self.camera_config = {**self.default_camera_config, **camera_config} |
Check warning
Code scanning / CodeQL
Overwriting attribute in super-class or sub-class
| self.construct() | ||
| except EndSceneEarlyException: | ||
| self.interact() | ||
| except EndScene: |
Check notice
Code scanning / CodeQL
Empty except
|
|
||
| from manim._config import logger as log | ||
| from manim.animation.animation import prepare_animation | ||
| from manim.animation.fading import VFadeInThenOut |
Check notice
Code scanning / CodeQL
Cyclic import
|
This will be merged into ManimCommunity/experimental` for further development |
1 participant
Porting all the new features from
3b1b/manimdrastical rewrite of the render system.Currently no explanation because it is highly experimental. Further discussion about this can be found on the discord server.