-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Porting Typing and new functionality from 3b1b/manim #2744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r uniform to accept ndarrays and convert to tuples later
d1b6457 to
8454fc3
Compare
updates: - [github.com/pre-commit/mirrors-mypy: v0.950 → v0.960](pre-commit/mirrors-mypy@v0.950...v0.960) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Bumps [pillow](https://github.com/python-pillow/Pillow) from 9.1.0 to 9.1.1. - [Release notes](https://github.com/python-pillow/Pillow/releases) - [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst) - [Commits](python-pillow/Pillow@9.1.0...9.1.1) --- updated-dependencies: - dependency-name: pillow dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ckling colour attribute lambda
Collaborator
Author
|
Depends on
|
Collaborator
Author
|
#3107 Will be continued here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
help wanted
We would appreciate help on this issue/PR
refactor
Refactor or redesign of existing code
testing
Anything related to testing the library
typehints
For adding/discussing typehints
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
This pull requests ports all the new changes from
3b1b/manimand adds type hints toOpenGLMobjectandOpenGLVmobjectCurrent annotations and state is pushed in https://github.com/MrDiver/manimlib
Every method commented with #DONE is already in this PR
TODO:
arrange_in_gridand our versionchangelog
OpenGLMobject
Additions:
init_constructor,__add__,__mul__,are_points_touching,is_touching,apply_over_attr_arrays,get_ancestors,insert_submobject,set_submobject,set_rgba_array,set_color_by_rgba_func,set_color_by_rgb_func,set_rgba_array_by_color,arrange_to_fit_dim,replicateRenamed:
set_rgba_array->set_rgba_array_by_color(added newset_rgba_array)set_rgba_array_direct->set_rgba_arrayRemoved/Depcrecated:
set_rgba_array_directChanges:
self.uniform.fixed_orientation_centeris now anp.ndarray__init__:self.x = xassignments and the rest of the constructor which is useful to see is now ininit_constructorset_points:asarrayinstead ofarrayto not unnecessarily copy arrays when not needed.add_updater:self.update(dt=0)set_color:set_rgba_array_by_colorinstead of setting color directlyset_opacity:set_rgba_array_by_colorinterpolate:fix_orientation:np.ndarrayto setfixed_orientation_centerinstead of tupleTemporary changes:
check_data_alignment:self.datainstead returns the new result directly to be used inget_resized_shader_data_arrayOpenGLVmobject
Additions:
@property:stroke_opacity,_stroke_opacity,@property:stroke_width,_stroke_widthRemoved/Deprecated
Changes:
Temporary changes:
Shader
Additions:
Removed/Deprecated
Changes:
set_uniform:np.ndarraytotuplefor easier outside usage to only need to convert on the last step when creating uniformsTemporary changes:
Color
Additions:
Removed/Deprecated
Changes:
rgb_to_hex:Temporary changes:
Motivation and Explanation: Why and how do your changes improve the library?
Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist