Skip to content

Fixed ignored depth_test argument for OpenGLVMobjects #3106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 27, 2023
Merged

Fixed ignored depth_test argument for OpenGLVMobjects #3106

merged 3 commits into from
Jan 27, 2023

Conversation

@Papierkorb2292
Copy link
Contributor

@Papierkorb2292 Papierkorb2292 commented Jan 1, 2023 •
edited by behackl
Loading

Overview: What does this pull request change?

Adds assignments from self.depth_test to SHADER_WRAPPER.depth_test in the update_SHADER_WRAPPER methods of OpenGLVMobject. Without this assignment, the depth_test parameter would not be given to the shaders and thus effectively ignored (as it is only assigned to self.depth_test, but not used further).

Motivation and Explanation: Why and how do your changes improve the library?

Links to added or changed documentation pages

Further Information and Comments

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

@MrDiver MrDiver added opengl Concerning the OpenGL renderer. pr:bugfix Bug fix for use in PRs solving a specific issue:bug labels Jan 2, 2023
@MrDiver MrDiver linked an issue Jan 2, 2023 that may be closed by this pull request
Rounding Corners doesn't work for OpenGL as well as Depth Testing #3100
Closed
MrDiver
MrDiver approved these changes Jan 2, 2023
View reviewed changes
Copy link
Collaborator

@MrDiver MrDiver left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you for the contribution. 🥳

This will also change with! #3107 But i will add it for now, because we don't know how long that change will take!

@alembcke
Copy link
Contributor

alembcke commented Jan 7, 2023

This PR fixes #2908.

@behackl behackl merged commit 262300c into ManimCommunity:main Jan 27, 2023
@behackl behackl mentioned this pull request Jan 27, 2023
Closed
@behackl behackl changed the title Fixes ignored depth_test parameter for OpenGLVMobjects Fixed ignored depth_test argument for OpenGLVMobjects Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MrDiver MrDiver MrDiver approved these changes

Assignees

@Papierkorb2292 Papierkorb2292

Labels

opengl Concerning the OpenGL renderer. pr:bugfix Bug fix for use in PRs solving a specific issue:bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rounding Corners doesn't work for OpenGL as well as Depth Testing

4 participants

@Papierkorb2292 @alembcke @MrDiver @behackl