-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Fixed render flow issues with introducer animations #2594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
|
Can you explain why the vector scene test data was changed? |
Sure, apologies for the very minimalistic PR description. I've had troubles with getting the last frame of the vector scene test data right with my changes (the diff always diverged in frame 36/36, which I still don't really have a good explanation for). Looking at the implementation of this animation sequence that is run in the test shows that actually, after the last animation, some mobjects are removed from the scene after the last animation has played. I've added an additional wait in the end to make sure that the "flickering" that the diff said was present is actually not there -- and it did indeed disappear from the control data as well after the wait was added. It might be worth to look into the scenario of removing a mobject after the last animation some more, but for all practical purposes this should not matter. |
|
If there are no general concerns, I'll merge this later today (in about 8h-ish or so from now) and proceed with preparing the bugfix release. |
icedcoffeeee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed this earlier, but forgot to submit the review. LGTM thanks!
Overview: What does this pull request change?
The recent PR adding the
is_introducermechanic for animations broke the waymoving_mobjectsandstatic_mobjectswere determined. This PR fixes these issues.Fixes #2585, #2598.
Motivation and Explanation: Why and how do your changes improve the library?
Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist