Skip to content

Conversation

@leotrs
Copy link
Contributor

@leotrs leotrs commented May 20, 2020

It seems that perf_scenes.py was added by someone making their own performance tests on an example scene. We can achieve the same but with a more organized test suite, in the future.

It is unclear to me exactly what stage_scenes.py is doing, but it is clearly only meant for the original author's private setup. If a script like this one becomes useful in the future, we can better position it inside a scripts/ folder, for example. It would not be hard to rewrite from scratch.

@eulertour
Copy link
Member

WDYT of removing the 3b1b stuff in LICENSE? Also, environment.yml was only for conda environments, which I'd suggest is too specific to be included in the upstream repo.

huguesdevimeux
huguesdevimeux previously approved these changes May 20, 2020
Copy link
Member

@huguesdevimeux huguesdevimeux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just wondering, Is a perf test a useful thing though ? We could easily implement itW

@eulertour
Copy link
Member

Also, what should be done about once_useful_constructs/? A lot of it is sure to not even work anymore.

@leotrs
Copy link
Contributor Author

leotrs commented May 20, 2020

@eulertour The NOTE.md in that folder reads

This folder contains a collection of various things that were built for a video at some point, but were really one-off and should be given more careful consideration before being brought into the main library. In particular, there is really no guarantee of these being fully functional.

I'd say we nuke the whole folder. If anything there is of interest for a future feature, we can always check those files out from Grant's repo.

@leotrs
Copy link
Contributor Author

leotrs commented May 20, 2020

RE the 3b1b stuff in LICENSE, since the folder it refers to has been deleted, we should delete it too. Yes?

@leotrs
Copy link
Contributor Author

leotrs commented May 20, 2020

OK I think that's about it for now.

@leotrs leotrs merged commit c83970f into ManimCommunity:master May 20, 2020
@PgBiel PgBiel added pr:deprecation Deprecation, or removal of deprecated code enhancement Additions and improvements in general labels May 20, 2020
@eulertour eulertour mentioned this pull request May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Additions and improvements in general pr:deprecation Deprecation, or removal of deprecated code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants