-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Remove unnecessary files #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
WDYT of removing the 3b1b stuff in LICENSE? Also, environment.yml was only for conda environments, which I'd suggest is too specific to be included in the upstream repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just wondering, Is a perf test a useful thing though ? We could easily implement itW
|
Also, what should be done about |
|
@eulertour The NOTE.md in that folder reads
I'd say we nuke the whole folder. If anything there is of interest for a future feature, we can always check those files out from Grant's repo. |
|
RE the 3b1b stuff in LICENSE, since the folder it refers to has been deleted, we should delete it too. Yes? |
|
OK I think that's about it for now. |
It seems that
perf_scenes.pywas added by someone making their own performance tests on an example scene. We can achieve the same but with a more organized test suite, in the future.It is unclear to me exactly what
stage_scenes.pyis doing, but it is clearly only meant for the original author's private setup. If a script like this one becomes useful in the future, we can better position it inside ascripts/folder, for example. It would not be hard to rewrite from scratch.