Skip to content

Conversation

@eulertour
Copy link
Member

Some files and functions missed in #2.

@TonyCrane
Copy link
Contributor

I think some people want to construct their own creature by modifying the code about pi_creature.
Is it better to delete this part of the code?

@leotrs
Copy link
Contributor

leotrs commented May 21, 2020

@eulertour were you able to run the example scenes after these deletions?

@leotrs
Copy link
Contributor

leotrs commented May 21, 2020

@tony031218 , the pi creatures are property of 3b1b, so we should totally delete them from this repo. If people are interested in mimicking them, they can always use the original 3b1b repository.

@eulertour
Copy link
Member Author

@leotrs Yes, I was still able to run them.

@eulertour eulertour requested a review from yoshiask May 21, 2020 03:37
@Aathish04
Copy link
Member

@eulertour were you able to run the example scenes after these deletions?

I wasn't able to run any of the example scenes after the removal of the files in once_useful_constructs. After manimlib.imports was suitably modified, then yeah, everything worked fine.

Why can't we leave once_useful_constructs in, anyway? They're just classes and methods that were useful before and might be in the future.

@eulertour
Copy link
Member Author

eulertour commented May 21, 2020

@Aathish04 Its last moments are documented here. It isn't part of the master branch anymore so you might have to pull.

@Aathish04
Copy link
Member

@Aathish04 Its last moments are documented here. It isn't part of the master branch anymore so you might have to pull.

I'm all for removing stale code. Can we also edit manimlib.imports and remove references to said cleaned up code then?

@eulertour
Copy link
Member Author

I'm not sure what you mean. This PR is already removing for_3b1b_videos from manimlib.imports and once_useful_constructs was removed in 3f5f0cb.

@Aathish04
Copy link
Member

I'm not sure what you mean. This PR is already removing for_3b1b_videos from manimlib.imports and once_useful_constructs was removed in 3f5f0cb.

Huh. The imports were still in the manimlib.imports on my computer... odd. It's probably just an issue on my end...

@eulertour eulertour requested a review from Aathish04 May 21, 2020 04:23
@eulertour eulertour merged commit 5e8d3e0 into master May 21, 2020
@leotrs leotrs deleted the remove-3b1b-files branch May 21, 2020 12:23
@PgBiel PgBiel added the pr:deprecation Deprecation, or removal of deprecated code label May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:deprecation Deprecation, or removal of deprecated code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants