-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Remove more 3b1b files #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think some people want to construct their own creature by modifying the code about pi_creature. |
|
@eulertour were you able to run the example scenes after these deletions? |
|
@tony031218 , the pi creatures are property of 3b1b, so we should totally delete them from this repo. If people are interested in mimicking them, they can always use the original 3b1b repository. |
|
@leotrs Yes, I was still able to run them. |
I wasn't able to run any of the example scenes after the removal of the files in Why can't we leave |
|
@Aathish04 Its last moments are documented here. It isn't part of the master branch anymore so you might have to pull. |
I'm all for removing stale code. Can we also edit manimlib.imports and remove references to said cleaned up code then? |
|
I'm not sure what you mean. This PR is already removing for_3b1b_videos from manimlib.imports and once_useful_constructs was removed in 3f5f0cb. |
Huh. The imports were still in the manimlib.imports on my computer... odd. It's probably just an issue on my end... |
Some files and functions missed in #2.