Skip to content

Conversation

@safinsingh
Copy link
Contributor

I think we should remove 3b1b-specific files for this community-based repo.

leotrs
leotrs previously requested changes May 19, 2020
Copy link
Contributor

@leotrs leotrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm down to delete the whole of the from_3b1b folder, but you also deleted some files related to travis, and setup.py too. Not sure we want to delete those.

@safinsingh
Copy link
Contributor Author

Do we need the travis file? Those are for pushing the repo to PyPi, which we're not deploying to (as of now). Also, setup.py was for travis to push the repo to PyPi.

@Aathish04
Copy link
Member

Do we need the travis file? Those are for pushing the repo to PyPi, which we're not deploying to (as of now). Also, setup.py was for travis to push the repo to PyPi.

@eulertour has mentioned that he would like to update the PyPI package in the near future, so it's probably better to leave it in.

@safinsingh
Copy link
Contributor Author

Sure; in that case, let me add those back

@safinsingh
Copy link
Contributor Author

Never mind, EulerTour says we don't need it for now.

@Aathish04 Aathish04 requested a review from leotrs May 19, 2020 03:50
@Aathish04 Aathish04 dismissed leotrs’s stale review May 19, 2020 04:03

The changes requested, as of now, are unnecessary, as we will not be using Travis in the near future.

Copy link
Member

@Aathish04 Aathish04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes made will serve to clean up the Manim repo.

@Aathish04 Aathish04 merged commit a63784f into master May 19, 2020
@Aathish04 Aathish04 deleted the remove-3b1b-specific-files branch May 19, 2020 04:08
@PgBiel PgBiel added the pr:deprecation Deprecation, or removal of deprecated code label May 20, 2020
@eulertour eulertour mentioned this pull request May 21, 2020
leotrs pushed a commit that referenced this pull request Jul 11, 2020
PhilippImhof pushed a commit to PhilippImhof/manim that referenced this pull request Oct 13, 2020
friedkeenan pushed a commit to friedkeenan/manim that referenced this pull request Feb 10, 2021
jsonvillanueva pushed a commit to jsonvillanueva/manim that referenced this pull request Mar 14, 2021
hickmott99 added a commit to hickmott99/manim that referenced this pull request Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:deprecation Deprecation, or removal of deprecated code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants