-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Remove 3b1b-specific files #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
leotrs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm down to delete the whole of the from_3b1b folder, but you also deleted some files related to travis, and setup.py too. Not sure we want to delete those.
|
Do we need the travis file? Those are for pushing the repo to PyPi, which we're not deploying to (as of now). Also, setup.py was for travis to push the repo to PyPi. |
@eulertour has mentioned that he would like to update the PyPI package in the near future, so it's probably better to leave it in. |
|
Sure; in that case, let me add those back |
|
Never mind, EulerTour says we don't need it for now. |
The changes requested, as of now, are unnecessary, as we will not be using Travis in the near future.
Aathish04
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes made will serve to clean up the Manim repo.
Added docstrings
I think we should remove 3b1b-specific files for this community-based repo.