Skip to content

Added instruction to test changes locally before taking a PR. [skip ci] #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 10, 2020
Merged

Added instruction to test changes locally before taking a PR. [skip ci] #155

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b277c0a
Added instruction to test changes locally before taking a PR. [skip ci]
Aathish04 Jun 14, 2020
76657ec
Added request for testing to General Contribution Guidelines
Aathish04 Jun 14, 2020
d0aecfc
Update CONTRIBUTING.md
PgBiel Jun 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
2. (For the maintainers of this repo) Label PRs appropriately.
3. Link relevant issues.
4. Ensure compatibility with the latest changes in the repo.
5. After you've made your changes, please test them out thoroughly. If the repository has any example code or code exclusively used for testing, please test your changes against those. If you have added new features, consider writing and contributing to a test for that feature to ensure it works properly.

## Contributing to the Manim Community Fork - General instructions

Expand Down Expand Up @@ -33,6 +34,8 @@ As this is a Fork of [Manim by 3b1b](https://github.com/3b1b/manim), contributin

4. After that, you can make your changes to the repo's files (the code is in the `manim` directory). Then, you can commit said changes.

> As stated in the General Contribution Guidelines, make sure to test your changes against the example scenes in the `example_scenes` directory and test scenes in the `tests` directory, and add a new test in the `tests` directory for your new feature if you've made one.

> Note: if your Pull Request doesn't change any of the actual code, please add `[skip ci]` to your commit message for Travis to ignore it.

5. Finally, instead of typing in `git push`, enter the command below.
Expand Down