Skip to content

Added instruction to test changes locally before taking a PR. [skip ci] #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 10, 2020
Merged

Added instruction to test changes locally before taking a PR. [skip ci] #155

merged 3 commits into from
Jul 10, 2020

Conversation

@Aathish04
Copy link
Member

@Aathish04 Aathish04 commented Jun 14, 2020

W.R.T #152
Added instructions for the contributor to test their changes locally, and to write tests for their new feature, if adding a new feature.

Should close #152 .

@Aathish04
Added instruction to test changes locally before taking a PR. [skip ci]
b277c0a 
W.R.T #152 
Added instructions for the contributor to test their changes locally, and to write tests if adding a new feature.

Should close #152 .
@PgBiel PgBiel added documentation Improvements or additions to documentation enhancement Additions and improvements in general infrastructure Anything related to our infrastructure testing Anything related to testing the library labels Jun 14, 2020
PgBiel
PgBiel requested changes Jun 14, 2020
View reviewed changes
Copy link
Member

@PgBiel PgBiel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add it to the general contribution guidelines instead (line 6) (maybe a small reference to it can be kept later)

Aathish04 and others added 2 commits June 14, 2020 10:33
@Aathish04
Added request for testing to General Contribution Guidelines
76657ec 
Added a note in the ManimCommunity Contribution Guidelines to do the same as well.
@PgBiel
Update CONTRIBUTING.md
d0aecfc
@huguesdevimeux
Copy link
Member

huguesdevimeux commented Jun 14, 2020 •
edited
Loading

Mmmh tbh I don't think that this PR is worth it, since when #133 will be merged the writing test process will be completely different as the one described here.
The test execution will also be different as it will use pytest.

In my opinion, we should wait for #133 to be merged before doing this.

@Aathish04
Copy link
Member Author

Aathish04 commented Jul 10, 2020

I sorta forgot about this PR.

@huguesdevimeux Now that #133 has been merged, can we merge this one as well?

@leotrs leotrs merged commit c077c5c into master Jul 10, 2020
@leotrs leotrs deleted the contrib-test-changes branch July 10, 2020 13:07
@leotrs leotrs mentioned this pull request Jul 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PgBiel PgBiel PgBiel approved these changes

+1 more reviewer

@leotrs leotrs leotrs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation enhancement Additions and improvements in general infrastructure Anything related to our infrastructure testing Anything related to testing the library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add to contribution guidelines that tests must be ran locally before submitting PR

5 participants

@Aathish04 @huguesdevimeux @leotrs @PgBiel