-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Configure the version number in LoopWorkspace, not Loop #2303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I will test this. |
|
I worry about confusion between the I tested that changing just the version in LoopWorkspace is sufficient to modify the display version number. |
|
We can set the version in Loop to 1.0, and add a note that it is typically overridden in the workspace. |
|
To clarify -
or
|
ps2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Purpose:
Simplify release process
Details
The Version.xcconfig file in the Loop repository is modified to point to the new file, LoopVersion.xcconfig, in the LoopWorkspace repository.
Associated PR
The LoopWorkspace PR 241 requires an update to the new Loop SHA after this PR is merged.