Skip to content

Conversation

@marionbarker
Copy link
Contributor

@marionbarker marionbarker commented Mar 29, 2025

Purpose:

Simplify release process

  • add a version number file to the LoopWorkspace folder and point to it from Version.xcconfig in the Loop folder
  • this requires coordinated PR for Loop and LoopWorkspace

Details

The Version.xcconfig file in the Loop repository is modified to point to the new file, LoopVersion.xcconfig, in the LoopWorkspace repository.

Associated PR

The LoopWorkspace PR 241 requires an update to the new Loop SHA after this PR is merged.

@marionbarker marionbarker requested review from itsmojo and ps2 March 29, 2025 05:38
@marionbarker
Copy link
Contributor Author

I will test this.

@marionbarker
Copy link
Contributor Author

I worry about confusion between the LOOP_MARKETING_VERSION in Loop and in LoopWorkspace.

I tested that changing just the version in LoopWorkspace is sufficient to modify the display version number.
I also tested that the branch name in LoopWorkspace is displayed on the settings screen of the Loop phone.

@ps2
Copy link
Collaborator

ps2 commented Apr 1, 2025

We can set the version in Loop to 1.0, and add a note that it is typically overridden in the workspace.

@marionbarker
Copy link
Contributor Author

To clarify -

  1. I leave the PR as is?

or

  1. I remove the expectation of VersionOverride.xcconfig in the Loop folder?
    • remove the one line in Loop Version.xcconfig so it only points up one folder (in which case, I think removing the version lines in the Version.xcconfig makes sense)
    • remove VersionOverride.xcconfig from Loop .gitignore

Copy link
Collaborator

@ps2 ps2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marionbarker marionbarker merged commit 0a3a165 into dev Apr 7, 2025
@marionbarker marionbarker deleted the move_version_file branch April 24, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants