Skip to content

Configure the version number in LoopWorkspace, not Loop #2303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 7, 2025
Merged

Configure the version number in LoopWorkspace, not Loop #2303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6a95dc9
Configure the version number in LoopWorkspace, not Loop
marionbarker Mar 29, 2025
93a0047
report the LoopWorkspace branch in Settings
marionbarker Mar 29, 2025
3b23771
Revert "Configure the version number in LoopWorkspace, not Loop"
marionbarker Apr 1, 2025
967bc7f
enable VersionOveride to be placed in LoopWorkspace
marionbarker Mar 31, 2025
faebc1a
reorder search for version override, add note about version for DIY Loop
marionbarker Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Loop/Managers/SupportManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ extension SupportManager: SupportUIDelegate {
}

private var branchNameIfNotReleaseBranch: String? {
return BuildDetails.default.gitBranch.filter { branch in
return BuildDetails.default.workspaceGitBranch.filter { branch in
return branch != "" &&
branch != "main" &&
branch != "master" &&
Expand Down
10 changes: 6 additions & 4 deletions Version.xcconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,11 @@
// Copyright © 2020 LoopKit Authors. All rights reserved.
//

// Version [DEFAULT]
LOOP_MARKETING_VERSION = 3.5.0
CURRENT_PROJECT_VERSION = 57
// Version
// [for DIY Loop] configure the version number in LoopWorkspace
LOOP_MARKETING_VERSION = 1.0
CURRENT_PROJECT_VERSION = 1

// Optional override
// Optional override (enables override of version)
#include? "../VersionOverride.xcconfig"
#include? "VersionOverride.xcconfig"