Skip to content

Conversation

@carmocca
Copy link
Contributor

@carmocca carmocca commented Sep 22, 2021

What does this PR do?

Part of #9661

Does your PR introduce any breaking changes? If yes, please list them.

Removes InternalDebugger.track_lr_schedulers_update

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added refactor breaking change Includes a breaking change labels Sep 22, 2021
@carmocca carmocca added this to the v1.5 milestone Sep 22, 2021
@carmocca carmocca self-assigned this Sep 22, 2021
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I couldn't figure out the tests quick enough ^^

@carmocca
Copy link
Contributor Author

LGTM, I couldn't figure out the tests quick enough ^^

Sorry! I didn't notice you had a draft

Copy link
Contributor

@ananthsub ananthsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this cleanup! Should we have an issue for tracking the various places the internal debugger is used? That could help coordinate who's working on what

@mergify mergify bot added the ready PRs ready to be merged label Sep 23, 2021
@carmocca carmocca mentioned this pull request Sep 23, 2021
7 tasks
@carmocca
Copy link
Contributor Author

Should we have an issue for tracking the various places the internal debugger is used? That could help coordinate who's working on what

Done in #9661

@carmocca carmocca enabled auto-merge (squash) September 23, 2021 01:47
@carmocca carmocca merged commit bffc534 into master Sep 23, 2021
@carmocca carmocca deleted the refactor/remove-track-lr-sch-updates branch September 23, 2021 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Includes a breaking change ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants