Skip to content

Conversation

@awaelchli
Copy link
Contributor

What does this PR do?

Follow up to #9188, #9326

Replaces the calls to the internal dev debugger in the optimizer connector. Tests are updated to cover what the "debugger" offered for tracking the calls inside the learning scheduler tracking.
This is just one step towards removing the InternalDebugger completely in favor of proper unit testing.

TODO:

  • update tests

Does your PR introduce any breaking changes? If yes, please list them.

No, the "InternalDebugger" is internal as the name suggests.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Make sure you had fun coding 🙃

@awaelchli awaelchli added the ci Continuous Integration label Sep 5, 2021
@stale
Copy link

stale bot commented Sep 19, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Sep 19, 2021
@awaelchli awaelchli added this to the v1.5 milestone Sep 20, 2021
@awaelchli
Copy link
Contributor Author

Closing in favor of #9653

@awaelchli awaelchli closed this Sep 22, 2021
@stale stale bot removed the won't fix This will not be worked on label Sep 22, 2021
@awaelchli awaelchli deleted the feature/dev_debugger/remove_lr branch September 22, 2021 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant