Skip to content

Logging Non-matching keys when loading from checkpoint in non-strict … #8152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 30, 2021
Merged

Logging Non-matching keys when loading from checkpoint in non-strict … #8152

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7d1e189
Logging Non-matching keys when loading from checkpoint in non-strict …
karthikrangasai Jun 27, 2021
c028afe
Update pytorch_lightning/core/saving.py
justusschock Jun 29, 2021
1bd11a5
Logging Non-matching keys when loading from checkpoint in non-strict …
karthikrangasai Jun 27, 2021
17488dc
Update pytorch_lightning/core/saving.py
justusschock Jun 29, 2021
5f41b7f
Updated warning message and to warn only when the keys are present
karthikrangasai Jun 30, 2021
4319889
Merge branch 'PyTorchLightning:master' into feature/8119_log-non-matc…
karthikrangasai Jun 30, 2021
8e4e1b4
Merge branch 'feature/8119_log-non-matching-keys-in-non-strict-mode' …
karthikrangasai Jun 30, 2021
0676eec
Updating grammar in warning messages.
karthikrangasai Jun 30, 2021
6ac56c4
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion pytorch_lightning/core/saving.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,17 @@ def _load_model_state(cls, checkpoint: Dict[str, Any], strict: bool = True, **cl
model.on_load_checkpoint(checkpoint)

# load the state_dict on the model automatically
model.load_state_dict(checkpoint['state_dict'], strict=strict)
keys = model.load_state_dict(checkpoint['state_dict'], strict=strict)

if not strict:
if keys.missing_keys:
rank_zero_warn(
f"Found keys that are in the model state dict but not in the checkpoint: {keys.missing_keys}"
)
if keys.unexpected_keys:
rank_zero_warn(
f"Found keys that are not in the model state dict but in the checkpoint: {keys.unexpected_keys}"
)

return model

Expand Down