Logging Non-matching keys when loading from checkpoint in non-strict … #8152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikrangasai
requested review from
Borda,
SeanNaren,
carmocca,
justusschock,
kaushikb11 and
tchaton
as code owners
ananthsub
reviewed
Jun 28, 2021
Co-authored-by: ananthsub <[email protected]>
justusschock
approved these changes
Jun 29, 2021
Codecov Report
@@ Coverage Diff @@
## master #8152 +/- ##
=======================================
- Coverage 93% 88% -5%
=======================================
Files 212 212
Lines 13595 13581 -14
=======================================
- Hits 12633 11941 -692
- Misses 962 1640 +678 |
carmocca
reviewed
Jun 29, 2021
Co-authored-by: ananthsub <[email protected]>
…hing-keys-in-non-strict-mode
https://github.com/karthikrangasai/pytorch-lightning into feature/8119_log-non-matching-keys-in-non-strict-mode
auto-merge was automatically disabled
June 30, 2021 08:05
Head branch was pushed to by a user without write access
carmocca
approved these changes
Jun 30, 2021
Contributor
carmocca
left a comment
carmocca
left a comment
There was a problem hiding this comment.
I don't think we need a test since this is just printing an output from PyTorch
SeanNaren
approved these changes
Jun 30, 2021
ananthsub
approved these changes
Jun 30, 2021
Co-authored-by: Carlos Mocholí <[email protected]>
|
Hello @karthikrangasai! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-06-30 17:33:21 UTC |
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When the model is loaded from a previous checkpoint with
strict=Falsewe can inform the user regarding the missing keys and unexpected keys.Fixes #8119
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃