Skip to content

Conversation

@SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Jun 14, 2021

What does this PR do?

As discussed in #7923 use model.half for pure FP16 training rather than having a specific argument for the plugin.

Fixes #<issue_number>

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@SeanNaren SeanNaren self-assigned this Jun 14, 2021
@SeanNaren SeanNaren added 3rd party Related to a 3rd-party feature Is an improvement or enhancement labels Jun 14, 2021
@SeanNaren SeanNaren added this to the v1.4 milestone Jun 14, 2021
@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #7974 (47d4a4d) into master (f7459f5) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #7974   +/-   ##
======================================
- Coverage      92%     91%   -0%     
======================================
  Files         203     203           
  Lines       13157   13151    -6     
======================================
- Hits        12043   12004   -39     
- Misses       1114    1147   +33     

@SeanNaren SeanNaren merged commit 024cf23 into master Jun 14, 2021
@SeanNaren SeanNaren deleted the fix/ipu_convert_to_half branch June 14, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3rd party Related to a 3rd-party feature Is an improvement or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants