Skip to content

Conversation

@SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Jun 10, 2021

What does this PR do?

Adds docs for IPUs.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@SeanNaren SeanNaren added docs Documentation related 3rd party Related to a 3rd-party labels Jun 10, 2021
@SeanNaren SeanNaren added this to the v1.4 milestone Jun 10, 2021
@SeanNaren SeanNaren self-assigned this Jun 10, 2021
@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #7923 (5a91005) into master (024cf23) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #7923   +/-   ##
======================================
- Coverage      92%     91%   -0%     
======================================
  Files         203     203           
  Lines       13151   13151           
======================================
- Hits        12042   12004   -38     
- Misses       1109    1147   +38     

Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice docs, clean and simple.

@SeanNaren SeanNaren changed the title [WIP] Added base docs for IPUs Added base docs for IPUs Jun 14, 2021
@SeanNaren SeanNaren marked this pull request as ready for review June 14, 2021 11:07
@SeanNaren SeanNaren changed the title Added base docs for IPUs Add docs for IPUs Jun 14, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great !

@SeanNaren SeanNaren enabled auto-merge (squash) June 14, 2021 14:18
@SeanNaren SeanNaren merged commit 0974d66 into master Jun 15, 2021
@SeanNaren SeanNaren deleted the docs/ipu branch June 15, 2021 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3rd party Related to a 3rd-party docs Documentation related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants