-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Clear predict_progress_bar in ProgressBar.__getstate__ #7608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
justusschock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awaelchli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good stuff!
Codecov Report
@@ Coverage Diff @@
## master #7608 +/- ##
=======================================
- Coverage 92% 88% -4%
=======================================
Files 197 198 +1
Lines 12878 12932 +54
=======================================
- Hits 11899 11370 -529
- Misses 979 1562 +583 |
carmocca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the test and updated the CHANGELOG
Co-authored-by: Yifu Wang <yifuwang@[email protected]> Co-authored-by: Justus Schock <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Carlos Mocholi <[email protected]>
Co-authored-by: Yifu Wang <yifuwang@[email protected]> Co-authored-by: Justus Schock <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Carlos Mocholi <[email protected]>
Co-authored-by: Yifu Wang <yifuwang@[email protected]> Co-authored-by: Justus Schock <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Carlos Mocholi <[email protected]>
What does this PR do?
Fixes #7567
tqdmis not pickle-able.ProgressBar.__getstate__()clearsmain_progress_bar,val_progress_bar, andtest_progress_barbut somehow notpredict_progress_bar. This PR addresses the issue.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃