Skip to content

Conversation

@justusschock
Copy link
Member

What does this PR do?

Fixes
Progressbar became unpickleable after predict.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented May 19, 2021

Hello @justusschock! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-05-19 10:58:51 UTC

@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #7609 (ac37895) into master (20f6337) will decrease coverage by 48%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #7609     +/-   ##
========================================
- Coverage      92%     44%    -48%     
========================================
  Files         197     197             
  Lines       12878   12875      -3     
========================================
- Hits        11899    5656   -6243     
- Misses        979    7219   +6240     

@Borda Borda deleted the bugfix/progressbar_pickling branch June 17, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants